[feature/rename-accounts] Rename Account without Authentication Flow #1097

hosy · 2022-01-31T09:08:35Z

Description

Check if only the account name was changed in edit mode: save and dismiss without re-authentication

Related Issue

#972

Motivation and Context

Easier account editing, without annoying the user with re-authentication

How Has This Been Tested?

Edit existing account
Change name
Tap on Continue
View should be dismissed without authentication flow
Try again with changing the URL or only changing the URL
Authentication should now happen

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
Added an issue with details about all relevant changes in the iOS documentation repository.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
Added changelog files for the fixed issues in folder changelog/unreleased

QA

Reports:

(1) Bad credentials pass [feature/rename-accounts] Rename Account without Authentication Flow #1097 (comment)
(2) Username missing [feature/rename-accounts] Rename Account without Authentication Flow #1097 (comment)
(3) OAuth2 flow [feature/rename-accounts] Rename Account without Authentication Flow #1097 (comment)

…ntication flow

ownCloud/Bookmarks/BookmarkViewController.swift

jesmrec · 2022-02-03T11:56:09Z

(1) [FIXED]

I got this one:

Edit account (basic auth)
In edit view, change name and then, enter incorrect credentials
Click on Continue

Current: No error displayed. When list of files is opened, the Authorization failed dialog raises up

Expected: (only an idea) when clicking on Continue, credentials checked in case they were filled up. If no credentials typed, only name saved.

iPhoneXR v15.3, iPadAir v14.8
b2d3f3ff

jesmrec · 2022-02-03T11:57:30Z

(2) [FIXED]

Probably related with (1)

In the Edit account view for basic auth:

Current: username is missing and editable.
Before: username was set and not editable.

Is this behaviour change expected?

iPhoneXR v15.3, iPadAir v14.8
b2d3f3ff

jesmrec · 2022-02-03T12:08:13Z

(3)

With browser authentication (OAuth2, OIDC) it's not posible to re-authenticate if the name changes. As defined above, URL has to change (i guess URLs does not use to change) to trigger the authentication flow. That means:

Credentials change in server
Edit Login (OAuth2) in app
Change name

Current: Continue changes the name but does not trigger the auth flow. As the credentials changed (this is the main reason to do an edit), the flow should be triggered.
Expected: Authentication flow triggered regardless name changes (am i right?)

For me it's not clear the expectation for this corner case in which both name and credentials are modified at the time.

iPhoneXR v15.3, iPadAir v14.8
b2d3f3ff

- show UI to delete authentication data in edit mode - only proceed without authentication, if authentication data is not nil

hosy · 2022-02-18T15:16:58Z

@jesmrec (1), (2), (3) are fixed:

show UI to delete authentication data in edit mode (please test, with one or more accounts configured, context menu, swipe action, edit table view action, if delete authentication UI appears)
only proceed without authentication, if authentication data is not nil

jesmrec · 2022-02-21T13:10:59Z

@hosy

(1) and (2) are fixed

(3) -> the way to re-authenticate with OAuth2 is with Delete Authentication Data right? otherwise, only the name changes. Please, confirm this is correct.

hosy · 2022-02-21T14:41:34Z

@jesmrec yes, this is correct.

jesmrec · 2022-02-22T08:17:31Z

jesmrec · 2022-02-22T08:23:35Z

For me this is approved!

* new version number 11.9.0, enabled beta build and warning * [feature/infinite-propfind] Infinite PROPFIND support (#1002) * - ProgressIndicatorViewController : extend with Progress object and cancellation support / monitoring - BookmarkViewController: add infinite PROPFIND prepopulation step after account creation - update SDK to provide infinite PROPFIND support * Configuration documentation updated * - update SDK to gain access to streaming infinite PROPFIND - switch from receive+parse to stream+parse for infinite PROPFIND * - update SDK to gain access to new supportsInfinitePropfind capability - BookmarkViewController: make prepopulation configurable, using new capability and new class setting - ProgressIndicatorViewController: add support for new title label view * - BookmarkViewController: fix property name typo - scheme: add new options to test streaming and split bookmark prepopulation * Configuration documentation updated * added additional build information to the Branding.plist file: - ios-app and ios-sdk commit hash - copy the Branding.plist with additional app and build information as file name * [feature/biometrical-mdm-setting ]Suggest Biometrical Unlock (#1046) * Suggest biometrical unlock, after setting up passcode * - do not show Cancel button, if password is enforced - update biometrical UI switch value in settings view - fixed bug, dismissing the view, if biometrical is not available * moved extension into ownCloudAppShared folder * Branding: (#1045) - add new `branding.user-defaults-default-values` class settings key to allow registration of alternative defaults for user defaults * - fix bug where a quick access entry showed no items when selected a second time. (#1044) * used better wording for "Cellular transfers" * - adjust to final capabilities naming for infinite PROPFIND support * upgraded app version numbers Co-authored-by: felix-schwarz <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> * [feature/poll-efficiency] Poll for changes efficiency enhancements (#1043) * - change text in the footer below private links in accordance with owncloud/enterprise#4726 * - SDK update * - ClientRootViewController: start OCFileProviderServiceStandby only - after the connection status is online (== authentication successful) - OR 5 seconds after receiving the core from the Core Manager - fix theoretical bug in ClientRootViewController where OCFileProviderServiceStandby could be started and not stopped if Core Manager returned a core with error * - bump version to 11.7.2 / build 202 * - FileProviderExtension: - handle case where OCDatabase is not available or not open (previously led to a hang/crash as the FP waited for a DB call to return) - disable malloc stack logging as it leads to immediate crashes when debugging the file provider * - update SDK to new version with support for coordinated scan for changes * - bump build number to 203 Co-authored-by: Matthias Hühne <[email protected]> * Configuration documentation updated * [fix/media-playback-url] Fix WebDAV endpoint URL for media playback after restoration (#1093) * - fix owncloud/enterprise#4924 via SDK update * Configuration documentation updated Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: hosy <[email protected]> * [feature/webfinger] Webfinger / server location (#1059) * - change text in the footer below private links in accordance with owncloud/enterprise#4726 * - SDK update * added additional build information to the Branding.plist file: - ios-app and ios-sdk commit hash - copy the Branding.plist with additional app and build information as file name * [feature/biometrical-mdm-setting ]Suggest Biometrical Unlock (#1046) * Suggest biometrical unlock, after setting up passcode * - do not show Cancel button, if password is enforced - update biometrical UI switch value in settings view - fixed bug, dismissing the view, if biometrical is not available * moved extension into ownCloudAppShared folder * Branding: (#1045) - add new `branding.user-defaults-default-values` class settings key to allow registration of alternative defaults for user defaults * - fix bug where a quick access entry showed no items when selected a second time. (#1044) * used better wording for "Cellular transfers" * - in branded clients: removed UISwitch to enable/disable deletion of available offline files in manage screen - fixed text center layout in table view cell * fixed UI issue in sharing view * #4801 "Log out" text changes * #4801 text changes for "Prevent gestures" * - ThemeTableViewCell, StaticTableViewRow: new .plain message style (#1053) - add new view controller to present license texts for each component individually * [feature/modular-localization] Modular localization (#1054) * - Branding class: - move logic for VendorServices.appName to Branding.appDisplayName - change app.name variable value to that of Branding.appDisplayName - switch String.localized from NSLocalizedString() to OCLocale.localize() - SwiftLint: adapt to latest SwiftLint version * - add .localized(replacements) function to provide easy access to custom variables support in OCLocale * - update SDK * [feature/mdm-auto-connect] Skip Account Screen via MDM (#1056) * #4801 Skip "Manage" screen / automatically open "Files" screen after login via MDM parameter account.auto-connect * - SceneDelegate: use .first (which returns nil in case there are no bookmarks) instead of bookmark(at: 0) (which crashes in case there are no bookmarks because the array is empty and the method tries to access an item at index 0) * added auto-connect after every setup, not only the first setup Co-authored-by: Felix Schwarz <[email protected]> * [feature/mdm-biometrical-unlock] MDM setting for Biometrical Unlock (#1058) * #4818 control via MDM to auto enable biometrical unlock * overwrites user defaults with MDM settings and use existing getter/setter; renamed MDM key to use-biometrical-unlock * - use user defaults for use-biometrical-unlock - show Face ID authorization immediately after enabling Face ID * - StaticLoginSetupViewController: add support for OCServerLocator, requesting a username if it is enabled - add additional debug options to ownCloud.xcscheme - update SDK to gain access to OCServerLocator * updated APP_VERSION number * reverted merge conflict changes * using correct SDK commit * using latest development sdk commit Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> * changed app version number * added missing translation string * [feature/rename-accounts] Rename Account without Authentication Flow (#1097) * #972 rename account name only (bookmark) is possible without re-authentication flow * added changelog entry * moved duplicated code into a function for reuse * fixed issue link in changelog entry * Calens changelog updated * fixed code review finding * fixed QA findings 1,2,3 - show UI to delete authentication data in edit mode - only proceed without authentication, if authentication data is not nil * show delete authentication data UI in all edit mode calls Co-authored-by: hosy <[email protected]> * #5008 (2) only show "Settings" toolbar, if no account is configured, otherwise "Settings" would appear twice * [feature/biometrical-button] Biometrical Authentication Button (#1098) * #1004 added biometrical unlock button, which appears by default as fallback, if biometrical unlock does not work (in file provider or not detected) * - added fallback image for face-id too - added changelog entry * Calens changelog updated * - fixed visibility of biometrical button in edit mode and, if feature is not enabled - removed unneeded code * - AppLockManager: add new property biometricCancelLabel to provide a label for the Cancel-option when presenting biometric authentication - FileProviderUI / DocumentActionViewController: use new property to display "Cancel" instead of "Enter code" for biometric authentication Co-authored-by: hosy <[email protected]> Co-authored-by: Felix Schwarz <[email protected]> * Calens changelog updated * removed branding test values * Transifex translation updates (#994) * disabled beta warning, beta build * - added accessibility label to biometrical unlock button - added release notes - added missing changelog files, moved to release folder * Calens changelog updated * added fastlane release notes * - update SDK to include fix/token-timetolerance changes from the SDK * changed folder name to release date * Calens changelog updated * - added missing changelog entry - changed enterprise issue to ios-app pr * Calens changelog updated * fixed duplicated app_version number on TestFlight Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: felix-schwarz <[email protected]> Co-authored-by: hosy <[email protected]> Co-authored-by: Matthias Hühne <>

…astlane via Branding.plist (#1099) * new version number 11.9.0, enabled beta build and warning * [feature/infinite-propfind] Infinite PROPFIND support (#1002) * - ProgressIndicatorViewController : extend with Progress object and cancellation support / monitoring - BookmarkViewController: add infinite PROPFIND prepopulation step after account creation - update SDK to provide infinite PROPFIND support * Configuration documentation updated * - update SDK to gain access to streaming infinite PROPFIND - switch from receive+parse to stream+parse for infinite PROPFIND * - update SDK to gain access to new supportsInfinitePropfind capability - BookmarkViewController: make prepopulation configurable, using new capability and new class setting - ProgressIndicatorViewController: add support for new title label view * - BookmarkViewController: fix property name typo - scheme: add new options to test streaming and split bookmark prepopulation * Configuration documentation updated * added additional build information to the Branding.plist file: - ios-app and ios-sdk commit hash - copy the Branding.plist with additional app and build information as file name * [feature/biometrical-mdm-setting ]Suggest Biometrical Unlock (#1046) * Suggest biometrical unlock, after setting up passcode * - do not show Cancel button, if password is enforced - update biometrical UI switch value in settings view - fixed bug, dismissing the view, if biometrical is not available * moved extension into ownCloudAppShared folder * Branding: (#1045) - add new `branding.user-defaults-default-values` class settings key to allow registration of alternative defaults for user defaults * - fix bug where a quick access entry showed no items when selected a second time. (#1044) * used better wording for "Cellular transfers" * - adjust to final capabilities naming for infinite PROPFIND support * upgraded app version numbers Co-authored-by: felix-schwarz <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> * [feature/poll-efficiency] Poll for changes efficiency enhancements (#1043) * - change text in the footer below private links in accordance with owncloud/enterprise#4726 * - SDK update * - ClientRootViewController: start OCFileProviderServiceStandby only - after the connection status is online (== authentication successful) - OR 5 seconds after receiving the core from the Core Manager - fix theoretical bug in ClientRootViewController where OCFileProviderServiceStandby could be started and not stopped if Core Manager returned a core with error * - bump version to 11.7.2 / build 202 * - FileProviderExtension: - handle case where OCDatabase is not available or not open (previously led to a hang/crash as the FP waited for a DB call to return) - disable malloc stack logging as it leads to immediate crashes when debugging the file provider * - update SDK to new version with support for coordinated scan for changes * - bump build number to 203 Co-authored-by: Matthias Hühne <[email protected]> * Configuration documentation updated * [fix/media-playback-url] Fix WebDAV endpoint URL for media playback after restoration (#1093) * - fix owncloud/enterprise#4924 via SDK update * Configuration documentation updated Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: hosy <[email protected]> * [feature/webfinger] Webfinger / server location (#1059) * - change text in the footer below private links in accordance with owncloud/enterprise#4726 * - SDK update * added additional build information to the Branding.plist file: - ios-app and ios-sdk commit hash - copy the Branding.plist with additional app and build information as file name * [feature/biometrical-mdm-setting ]Suggest Biometrical Unlock (#1046) * Suggest biometrical unlock, after setting up passcode * - do not show Cancel button, if password is enforced - update biometrical UI switch value in settings view - fixed bug, dismissing the view, if biometrical is not available * moved extension into ownCloudAppShared folder * Branding: (#1045) - add new `branding.user-defaults-default-values` class settings key to allow registration of alternative defaults for user defaults * - fix bug where a quick access entry showed no items when selected a second time. (#1044) * used better wording for "Cellular transfers" * - in branded clients: removed UISwitch to enable/disable deletion of available offline files in manage screen - fixed text center layout in table view cell * fixed UI issue in sharing view * #4801 "Log out" text changes * #4801 text changes for "Prevent gestures" * - ThemeTableViewCell, StaticTableViewRow: new .plain message style (#1053) - add new view controller to present license texts for each component individually * [feature/modular-localization] Modular localization (#1054) * - Branding class: - move logic for VendorServices.appName to Branding.appDisplayName - change app.name variable value to that of Branding.appDisplayName - switch String.localized from NSLocalizedString() to OCLocale.localize() - SwiftLint: adapt to latest SwiftLint version * - add .localized(replacements) function to provide easy access to custom variables support in OCLocale * - update SDK * [feature/mdm-auto-connect] Skip Account Screen via MDM (#1056) * #4801 Skip "Manage" screen / automatically open "Files" screen after login via MDM parameter account.auto-connect * - SceneDelegate: use .first (which returns nil in case there are no bookmarks) instead of bookmark(at: 0) (which crashes in case there are no bookmarks because the array is empty and the method tries to access an item at index 0) * added auto-connect after every setup, not only the first setup Co-authored-by: Felix Schwarz <[email protected]> * [feature/mdm-biometrical-unlock] MDM setting for Biometrical Unlock (#1058) * #4818 control via MDM to auto enable biometrical unlock * overwrites user defaults with MDM settings and use existing getter/setter; renamed MDM key to use-biometrical-unlock * - use user defaults for use-biometrical-unlock - show Face ID authorization immediately after enabling Face ID * - StaticLoginSetupViewController: add support for OCServerLocator, requesting a username if it is enabled - add additional debug options to ownCloud.xcscheme - update SDK to gain access to OCServerLocator * updated APP_VERSION number * reverted merge conflict changes * using correct SDK commit * using latest development sdk commit Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> * changed app version number * #4918 added the possiblity, to set a custom app group identifier via Branding.plist parameter "build.app-group-identifier", which will be set by fastlane to all needed key/value pairs. This is needed, if customer using a own resigning script, which does not handle setting the app group identifier. * added documentation and changelog entry * Calens changelog updated * - add additional parameter build.oc-app-group-identifier that only changes the OCAppGroupIdentifier and OCKeychainAccessGroupIdentifier keys in Info.plist * - add ownCloud/Resources/Info.plist to list of files to replace OCAppGroupIdentifier and OCKeychainAccessGroupIdentifier in * added documentation for the new build key * added missing translation string * [feature/rename-accounts] Rename Account without Authentication Flow (#1097) * #972 rename account name only (bookmark) is possible without re-authentication flow * added changelog entry * moved duplicated code into a function for reuse * fixed issue link in changelog entry * Calens changelog updated * fixed code review finding * fixed QA findings 1,2,3 - show UI to delete authentication data in edit mode - only proceed without authentication, if authentication data is not nil * show delete authentication data UI in all edit mode calls Co-authored-by: hosy <[email protected]> * #5008 (2) only show "Settings" toolbar, if no account is configured, otherwise "Settings" would appear twice * [feature/biometrical-button] Biometrical Authentication Button (#1098) * #1004 added biometrical unlock button, which appears by default as fallback, if biometrical unlock does not work (in file provider or not detected) * - added fallback image for face-id too - added changelog entry * Calens changelog updated * - fixed visibility of biometrical button in edit mode and, if feature is not enabled - removed unneeded code * - AppLockManager: add new property biometricCancelLabel to provide a label for the Cancel-option when presenting biometric authentication - FileProviderUI / DocumentActionViewController: use new property to display "Cancel" instead of "Enter code" for biometric authentication Co-authored-by: hosy <[email protected]> Co-authored-by: Felix Schwarz <[email protected]> * Calens changelog updated * Calens changelog updated * Calens changelog updated * fixed merge conflicts * Calens changelog updated * fixed syntax error * fixed syntax error * added missing changelog entry * Calens changelog updated Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: felix-schwarz <[email protected]> Co-authored-by: hosy <[email protected]> Co-authored-by: Matthias Hühne <>

* - BookmarkViewController: re-add infinite PROPFIND code previously removed due to a merge error - update CHANGELOG.md - bump build and version numbers - update ios-sdk to increase timeout for start of response to infinite PROPFIND from 30 seconds to 6 minutes * Calens changelog updated * [feature/fastlane-app-group-identifier] Set App Group Identifier by Fastlane via Branding.plist (#1099) * new version number 11.9.0, enabled beta build and warning * [feature/infinite-propfind] Infinite PROPFIND support (#1002) * - ProgressIndicatorViewController : extend with Progress object and cancellation support / monitoring - BookmarkViewController: add infinite PROPFIND prepopulation step after account creation - update SDK to provide infinite PROPFIND support * Configuration documentation updated * - update SDK to gain access to streaming infinite PROPFIND - switch from receive+parse to stream+parse for infinite PROPFIND * - update SDK to gain access to new supportsInfinitePropfind capability - BookmarkViewController: make prepopulation configurable, using new capability and new class setting - ProgressIndicatorViewController: add support for new title label view * - BookmarkViewController: fix property name typo - scheme: add new options to test streaming and split bookmark prepopulation * Configuration documentation updated * added additional build information to the Branding.plist file: - ios-app and ios-sdk commit hash - copy the Branding.plist with additional app and build information as file name * [feature/biometrical-mdm-setting ]Suggest Biometrical Unlock (#1046) * Suggest biometrical unlock, after setting up passcode * - do not show Cancel button, if password is enforced - update biometrical UI switch value in settings view - fixed bug, dismissing the view, if biometrical is not available * moved extension into ownCloudAppShared folder * Branding: (#1045) - add new `branding.user-defaults-default-values` class settings key to allow registration of alternative defaults for user defaults * - fix bug where a quick access entry showed no items when selected a second time. (#1044) * used better wording for "Cellular transfers" * - adjust to final capabilities naming for infinite PROPFIND support * upgraded app version numbers Co-authored-by: felix-schwarz <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> * [feature/poll-efficiency] Poll for changes efficiency enhancements (#1043) * - change text in the footer below private links in accordance with owncloud/enterprise#4726 * - SDK update * - ClientRootViewController: start OCFileProviderServiceStandby only - after the connection status is online (== authentication successful) - OR 5 seconds after receiving the core from the Core Manager - fix theoretical bug in ClientRootViewController where OCFileProviderServiceStandby could be started and not stopped if Core Manager returned a core with error * - bump version to 11.7.2 / build 202 * - FileProviderExtension: - handle case where OCDatabase is not available or not open (previously led to a hang/crash as the FP waited for a DB call to return) - disable malloc stack logging as it leads to immediate crashes when debugging the file provider * - update SDK to new version with support for coordinated scan for changes * - bump build number to 203 Co-authored-by: Matthias Hühne <[email protected]> * Configuration documentation updated * [fix/media-playback-url] Fix WebDAV endpoint URL for media playback after restoration (#1093) * - fix owncloud/enterprise#4924 via SDK update * Configuration documentation updated Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: hosy <[email protected]> * [feature/webfinger] Webfinger / server location (#1059) * - change text in the footer below private links in accordance with owncloud/enterprise#4726 * - SDK update * added additional build information to the Branding.plist file: - ios-app and ios-sdk commit hash - copy the Branding.plist with additional app and build information as file name * [feature/biometrical-mdm-setting ]Suggest Biometrical Unlock (#1046) * Suggest biometrical unlock, after setting up passcode * - do not show Cancel button, if password is enforced - update biometrical UI switch value in settings view - fixed bug, dismissing the view, if biometrical is not available * moved extension into ownCloudAppShared folder * Branding: (#1045) - add new `branding.user-defaults-default-values` class settings key to allow registration of alternative defaults for user defaults * - fix bug where a quick access entry showed no items when selected a second time. (#1044) * used better wording for "Cellular transfers" * - in branded clients: removed UISwitch to enable/disable deletion of available offline files in manage screen - fixed text center layout in table view cell * fixed UI issue in sharing view * #4801 "Log out" text changes * #4801 text changes for "Prevent gestures" * - ThemeTableViewCell, StaticTableViewRow: new .plain message style (#1053) - add new view controller to present license texts for each component individually * [feature/modular-localization] Modular localization (#1054) * - Branding class: - move logic for VendorServices.appName to Branding.appDisplayName - change app.name variable value to that of Branding.appDisplayName - switch String.localized from NSLocalizedString() to OCLocale.localize() - SwiftLint: adapt to latest SwiftLint version * - add .localized(replacements) function to provide easy access to custom variables support in OCLocale * - update SDK * [feature/mdm-auto-connect] Skip Account Screen via MDM (#1056) * #4801 Skip "Manage" screen / automatically open "Files" screen after login via MDM parameter account.auto-connect * - SceneDelegate: use .first (which returns nil in case there are no bookmarks) instead of bookmark(at: 0) (which crashes in case there are no bookmarks because the array is empty and the method tries to access an item at index 0) * added auto-connect after every setup, not only the first setup Co-authored-by: Felix Schwarz <[email protected]> * [feature/mdm-biometrical-unlock] MDM setting for Biometrical Unlock (#1058) * #4818 control via MDM to auto enable biometrical unlock * overwrites user defaults with MDM settings and use existing getter/setter; renamed MDM key to use-biometrical-unlock * - use user defaults for use-biometrical-unlock - show Face ID authorization immediately after enabling Face ID * - StaticLoginSetupViewController: add support for OCServerLocator, requesting a username if it is enabled - add additional debug options to ownCloud.xcscheme - update SDK to gain access to OCServerLocator * updated APP_VERSION number * reverted merge conflict changes * using correct SDK commit * using latest development sdk commit Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> * changed app version number * #4918 added the possiblity, to set a custom app group identifier via Branding.plist parameter "build.app-group-identifier", which will be set by fastlane to all needed key/value pairs. This is needed, if customer using a own resigning script, which does not handle setting the app group identifier. * added documentation and changelog entry * Calens changelog updated * - add additional parameter build.oc-app-group-identifier that only changes the OCAppGroupIdentifier and OCKeychainAccessGroupIdentifier keys in Info.plist * - add ownCloud/Resources/Info.plist to list of files to replace OCAppGroupIdentifier and OCKeychainAccessGroupIdentifier in * added documentation for the new build key * added missing translation string * [feature/rename-accounts] Rename Account without Authentication Flow (#1097) * #972 rename account name only (bookmark) is possible without re-authentication flow * added changelog entry * moved duplicated code into a function for reuse * fixed issue link in changelog entry * Calens changelog updated * fixed code review finding * fixed QA findings 1,2,3 - show UI to delete authentication data in edit mode - only proceed without authentication, if authentication data is not nil * show delete authentication data UI in all edit mode calls Co-authored-by: hosy <[email protected]> * #5008 (2) only show "Settings" toolbar, if no account is configured, otherwise "Settings" would appear twice * [feature/biometrical-button] Biometrical Authentication Button (#1098) * #1004 added biometrical unlock button, which appears by default as fallback, if biometrical unlock does not work (in file provider or not detected) * - added fallback image for face-id too - added changelog entry * Calens changelog updated * - fixed visibility of biometrical button in edit mode and, if feature is not enabled - removed unneeded code * - AppLockManager: add new property biometricCancelLabel to provide a label for the Cancel-option when presenting biometric authentication - FileProviderUI / DocumentActionViewController: use new property to display "Cancel" instead of "Enter code" for biometric authentication Co-authored-by: hosy <[email protected]> Co-authored-by: Felix Schwarz <[email protected]> * Calens changelog updated * Calens changelog updated * Calens changelog updated * fixed merge conflicts * Calens changelog updated * fixed syntax error * fixed syntax error * added missing changelog entry * Calens changelog updated Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: felix-schwarz <[email protected]> Co-authored-by: hosy <[email protected]> Co-authored-by: Matthias Hühne <> * updated changelog and release notes * Calens changelog updated * - SDK update to improve handling of token refresh "responses" while offline - add scheme env variable to turn on/off auth race condition simulator * - ios-sdk update: fix dead-lock - BookmarkViewController: fix finding (1) in #1109 * - update commit to latest develop commit including OCBookmarkManager deadlock fix * - change SDK to latest develop version * [fix/biometrical-unlock-setup] Fix: Setup Passcode with Biometrical Unlock (#1112) * #5086 fix for passcode setup with biometrical unlock enabled: - biometrical unlock button no longer appear in setup view - after passcode was successfully setup, show biometrical unlock for permissions dialog * removed unneeded comment * added changelog and release notes * Calens changelog updated * reverted to Xcode 12 version * - update to SDK release 11.9.1 (master) * changed folder name for changelog release * Calens changelog updated Co-authored-by: felix-schwarz <[email protected]> Co-authored-by: Matthias Hühne <[email protected]> Co-authored-by: hosy <[email protected]> Co-authored-by: Matthias Hühne <>

#972 rename account name only (bookmark) is possible without re-authe…

fe4e2d4

…ntication flow

hosy added this to the 11.9.0-Current milestone Jan 31, 2022

hosy requested review from felix-schwarz and jesmrec January 31, 2022 09:08

hosy self-assigned this Jan 31, 2022

hosy linked an issue Jan 31, 2022 that may be closed by this pull request

[FEATURE REQUEST] Rename accounts without the login flow #972

Closed

9 tasks

hosy and others added 4 commits January 31, 2022 10:10

added changelog entry

0e3072f

moved duplicated code into a function for reuse

401507e

fixed issue link in changelog entry

71ee834

Calens changelog updated

e58afcc

felix-schwarz requested changes Feb 1, 2022

View reviewed changes

ownCloud/Bookmarks/BookmarkViewController.swift Outdated Show resolved Hide resolved

fixed code review finding

b2d3f3f

hosy requested a review from felix-schwarz February 2, 2022 09:19

felix-schwarz approved these changes Feb 2, 2022

View reviewed changes

hosy added 2 commits February 18, 2022 16:12

fixed QA findings 1,2,3

4734616

- show UI to delete authentication data in edit mode - only proceed without authentication, if authentication data is not nil

show delete authentication data UI in all edit mode calls

55c97dd

jesmrec approved these changes Feb 22, 2022

View reviewed changes

jesmrec added the Approved by QA Approved by QA label Feb 22, 2022

hosy merged commit 54a9d8d into milestone/11.9.0 Feb 22, 2022

delete-merged-branch bot deleted the feature/rename-accounts branch February 22, 2022 08:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature/rename-accounts] Rename Account without Authentication Flow #1097

[feature/rename-accounts] Rename Account without Authentication Flow #1097

hosy commented Jan 31, 2022 •

edited by jesmrec

Loading

jesmrec commented Feb 3, 2022 •

edited

Loading

jesmrec commented Feb 3, 2022 •

edited

Loading

jesmrec commented Feb 3, 2022

hosy commented Feb 18, 2022

jesmrec commented Feb 21, 2022

hosy commented Feb 21, 2022

jesmrec commented Feb 22, 2022

jesmrec commented Feb 22, 2022

[feature/rename-accounts] Rename Account without Authentication Flow #1097

[feature/rename-accounts] Rename Account without Authentication Flow #1097

Conversation

hosy commented Jan 31, 2022 • edited by jesmrec Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

QA

jesmrec commented Feb 3, 2022 • edited Loading

(1) [FIXED]

jesmrec commented Feb 3, 2022 • edited Loading

(2) [FIXED]

jesmrec commented Feb 3, 2022

(3)

hosy commented Feb 18, 2022

jesmrec commented Feb 21, 2022

hosy commented Feb 21, 2022

jesmrec commented Feb 22, 2022

jesmrec commented Feb 22, 2022

hosy commented Jan 31, 2022 •

edited by jesmrec

Loading

jesmrec commented Feb 3, 2022 •

edited

Loading

jesmrec commented Feb 3, 2022 •

edited

Loading