Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Previews] Image gallery #85

Closed
9 tasks
javiergonzper opened this issue Jun 20, 2018 · 5 comments
Closed
9 tasks

[Previews] Image gallery #85

javiergonzper opened this issue Jun 20, 2018 · 5 comments
Assignees
Labels
Design Estimation - 3 (M) 3 points feature:previews p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@javiergonzper
Copy link
Contributor

javiergonzper commented Jun 20, 2018

As a user, i want the possibility see the images of a folder on the ownCloud iOS App

AC:

  • When the user select an image on the File list the gallery should be open showing the selected image
  • The gallery load all the images in the order of the File list
  • The gallery should have in memory the current image, the next and the previous one
  • The files should be cached
  • Pinch to zoom
  • The gallery should allow full screen with one tap on the screen and exit from background with one tap
  • The image have to be loaded touching the limits of the screen on the higher size (including under Navigation bar and Status bar to prevent blinks when enter on full screen)
  • The title on the Navigation bar have to change once the new image are over the middle of the transition
  • The transition should have a separation between images

Mockups:

Image preview

01 image preview loading


image preview 1

Transition

image preview 2 - transition

Transition loading

02 image preview transition loading

Image portrait
image preview 3

Image portrait full screen
image preview 4

Image landscape full screen
image preview 5

Figma design:
https://www.figma.com/file/Ui4YzD3oQcxJSbzBEr80O9eU/Working-Draft-UI?node-id=1746%3A228

@jesmrec
Copy link
Contributor

jesmrec commented Jun 21, 2018

the easier, the better. Works for me.

@michaelstingl
Copy link
Contributor

Cool idea from @atwm :

Previews for RAW files (photos). Raw files normally include jpeg previews which can be extracted and shown

Sounds feasible (for later release). This is what a quick Google search brought up: https://gentlemencoders.com/how-raw-works-on-ios/

@atwm
Copy link

atwm commented Jul 5, 2018

I think to start off with, it would already be enough to show the embedded jpeg in the file overview. This would save resources (bandwidth, disk space). (Rather be fast than accurate) In particular for a file that has not been downloaded. My use case is that I go to the Files app and select the photos I want to continue to work on. Then I use a RAW editor (Affinity Photo, LightRoom CC, etc ) download and edit.

Of course, if a File has been downloaded, the iOS Raw decoder could be used to show an improved preview.

But to begin with, I really would settle for the embedded preview. Dropbox supports this and it is one of the reasons that I use Dropbox instead of ownCloud. Only seeing a generic file icon when looking through several dozens of RAW files, without knowing what you are dealing with is frustrating.

@michaelstingl
Copy link
Contributor

@atwm while thinking I found, this needs to be processed on the server-side to only send small previews to the mobile clients.

This has been discussed before:

I also posted a bounty for the camerarawpreviews app to get this to the ownCloud Marketplace.

@jesmrec jesmrec modified the milestone: 0.1.0 Sep 27, 2018
@jesmrec jesmrec mentioned this issue Oct 11, 2018
11 tasks
@jesmrec jesmrec added this to the 0.3.0 milestone Nov 29, 2018
@michaelstingl michaelstingl modified the milestones: 0.3.0, backlog Dec 4, 2018
@jesmrec jesmrec modified the milestones: backlog, 1.1.0 Feb 1, 2019
@michaelstingl michaelstingl added p3-medium Normal priority p2-high Escalation, on top of current planning, release blocker and removed p3-medium Normal priority labels Feb 6, 2019
@jesmrec jesmrec removed the discussion label Mar 6, 2019
@jesmrec
Copy link
Contributor

jesmrec commented Mar 15, 2019

Done!

@jesmrec jesmrec closed this as completed Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Estimation - 3 (M) 3 points feature:previews p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

No branches or pull requests

5 participants