Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi selection on the file list #79

Closed
7 tasks
javiergonzper opened this issue Jun 15, 2018 · 11 comments
Closed
7 tasks

Multi selection on the file list #79

javiergonzper opened this issue Jun 15, 2018 · 11 comments
Assignees
Labels
Milestone

Comments

@javiergonzper
Copy link
Contributor

javiergonzper commented Jun 15, 2018

As a user, i want the possibility to select multiple files or folders and do actions with them

AC:

  • On the Navigation bar of the file list add a button Select to enter on the Multi selection mode
  • Once you enter on the Multi selection mode you should be able to select any file or folder from that path (you can not navigate, only select files or folders).
  • On the bottom you have a Tool Bar where should appear the following actions:
    • Move
    • Available Offline
    • Open With...
    • Delete

Mockups:

multiselection

multiselection selected

***Note: The actions should be implemented on a different user story to not make this so huge.

Figma:
https://www.figma.com/file/Ui4YzD3oQcxJSbzBEr80O9eU/Working-Draft-UI?node-id=1585%3A14

@jesmrec
Copy link
Contributor

jesmrec commented Jun 21, 2018

the operations to place in the bottom bar will be available only for several items? I mean: removing, moving, setting as av. offline make sense to involve several items together, but other options like renaming or opening with an external app does make sense for only one item.

So, if i select only one item, will i have the one-item operations available in multiselection mode? or only the operations for several items?

@javiergonzper
Copy link
Contributor Author

If you want to make operations with just one item you have the "..." button (not shown yet on the mockup of the file list but visible on the preview).

This view it is think to make operation with several files. If you just select one file you can do all the operations allowed to be used on several files but in just one.

In my opinion we should not cover all the actions that are covered by other views.

@pablocarmu
Copy link
Contributor

Thinking about the implementation of the multiple delete, one possible "issue" is that the SDK currently does not support batch commands without updating the ongoing query in ClientQueryViewController.

The easiest thing we could do is stop/pause the query at the same time we perform the multi-delete and then, once the multi-operation finishes or some error appear, we can present the updated results to the user simply resuming the paused query.

If I remember well, another solution by @felix-schwarz came up in one call but I cannot remember the exact proposal/solution.

Not sure if this should be resolved by the app or maybe the SDK should provide some mechanisms to make batch commands like multi-delete. We could open an issue in the SDK repo and discuss it there.

@michaelstingl
Copy link
Contributor

michaelstingl commented Jul 3, 2018

  • Cancel top-right to quit multiselect mode? iOS 12 Files app uses Done too. @felix-schwarz preference?
  • Select all on top left or elsewhere?

@jesmrec jesmrec modified the milestones: 0.1.0, 0.2.0 Sep 27, 2018
@michaelstingl michaelstingl added the p2-high Escalation, on top of current planning, release blocker label Oct 23, 2018
@michaelstingl michaelstingl added p3-medium Normal priority and removed p2-high Escalation, on top of current planning, release blocker labels Nov 21, 2018
@jesmrec jesmrec modified the milestones: 0.2.0, 0.3.0 Nov 29, 2018
@michaelstingl michaelstingl added p4-low Low priority and removed p3-medium Normal priority labels Dec 4, 2018
@michaelstingl michaelstingl modified the milestones: 0.3.0, 0.4.0 Jan 4, 2019
@michaelstingl michaelstingl added p3-medium Normal priority and removed p4-low Low priority labels Jan 4, 2019
@jesmrec jesmrec self-assigned this Jan 11, 2019
@jesmrec
Copy link
Contributor

jesmrec commented Jan 11, 2019

First iteration:

  • Delete
  • Move items to existing folder
  • Move items to new folder

@ShockwaverReal
Copy link

ShockwaverReal commented Jan 24, 2019

It could be very useful (AKA we miss it like crazy when we need it and we don't have it) to have the action

  • Save N files

It could even be limited to images and videos mime types and the save location could be the default location for photo shots.

I think it's quite the common scenario where you shoot photos with cameras, you save them on your ownCloud and then you want to have some of them in your in-device photo-roll

The multiple selection could be checked against the only presence of image and videos mime-types and, if so, one action could be added to the list "Save on device" or "Save N photos" or....

think about saving even just 50-100 photos on device INDIVIDUALLY (once I did it and it was that unpleasent I had to delegate it to my child XD)

img_262a521184ab-1

Sorry for the italian, the option would be "Save 2 images"

@michaelstingl
Copy link
Contributor

Seems this only works with images and videos (compatible with Photos app). It already works when you use Open in with a single file. @mneuwert Will Save Image(s) "just work" with multiple files as well?

@ShockwaverReal
Copy link

As a note.
I just noticed the feature is somewhat present in the beta App support for File location App
You can multi-select, then you need to make sure they are downloaded (they need not to have the cloud icon overlay on the thumbnails) choosing the Copy action for example, and then you can save them on device... yes they need to be reselected
photo-2019-01-25-00-41-14_6427
photo-2019-01-25-00-41-14_6424
photo-2019-01-25-00-41-15_6428

@jesmrec jesmrec mentioned this issue Feb 1, 2019
4 tasks
@michaelstingl
Copy link
Contributor

@ShockwaverReal sorry, won't be in the first release, but will follow in a future release… (see #246)

@michaelstingl michaelstingl mentioned this issue Feb 3, 2019
2 tasks
@jesmrec
Copy link
Contributor

jesmrec commented Feb 4, 2019

Work resumed in #246

@jesmrec jesmrec closed this as completed Feb 4, 2019
@ShockwaverReal
Copy link

ShockwaverReal commented Feb 4, 2019

will follow in a future release… (see #246)

Work resumed in #246

Terrific!
That's perfect also because in the meanwhile I can do with the integration in Files App!
Thanks again guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants