Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Preview #68

Open
jesmrec opened this issue Jun 8, 2018 · 5 comments
Open

File Preview #68

jesmrec opened this issue Jun 8, 2018 · 5 comments

Comments

@jesmrec
Copy link
Contributor

jesmrec commented Jun 8, 2018

This issue intends to be an epic to discuss about the way to preview downloaded files

Issues to take in account:

  • Security: for files like MS Office ones or web can execute macros or js pointing to malicious targets (phising attacks etc...)... using WKWebView as in Update UIWebView to WKWebView ios-legacy#1046

  • Pics: the point here is using or not a preview in "streaming" mode (caching the image in less resolution instead of downloading it) to save both bandwidth and storage. For images / animated gifs, setting a Gallery mode should be a must.

  • Edition mode: currently available for txt files, embedded in preview mode.

  • Operations in preview mode: apart of preview the file, some shortcuts can be provided (thinking in the future), like deleting, sharing, downloading, set as available offline (always synced), send...

  • Video: streaming for secured connections

  • Audio: streaming for secured connections

@michaelstingl
Copy link
Contributor

Txt file editing: No priority. Needs another discussion about encoding etc someday maybe. With Files app integration it's very easy to use a better 3rd party text editor.

@michaelstingl
Copy link
Contributor

I've got questions about audio streaming. Are there file formats that support this? Can this work similar to video streaming?

@javiergonzper
Copy link
Contributor

I've got questions about audio streaming. Are there file formats that support this? Can this work similar to video streaming?

@michaelstingl It is very similar for video and audio (mostly is the same). We should use AVFundation to play them.
After reading the AVMediaFormat.h all the supported files are:

com.apple.quicktime-movie: .mov and .qt
public.mpeg-4: .mp4
com.apple.m4v-video: .m4v
com.apple.m4a-audio: .m4a
public.3gpp: .3gp, .3gpp, and .sdv
public.3gpp2: .3g2, .3gp2
com.apple.coreaudio-format: .caf
com.microsoft.waveform-audio: .wav, .wave, and .bwf
public.aiff-audio: .aif and .aiff
public.aifc-audio: .aifc and .cdda
org.3gpp.adaptive-multi-rate-audio: .amr
public.mp3: .mp3
public.au-audio: .au and .snd
public.ac3-audio: .ac3
public.enhanced-ac3-audio: .eac3
public.jpeg: .jpg or .jpeg
com.adobe.raw-image: .dng
public.heic: .heic
public.avci: .avci
public.heif: .heif
public.tiff: .tiff or .tif

@javiergonzper
Copy link
Contributor

As an initial work we should create a default "File Preview" to open it before the file was loaded (or downloaded).

Also I am working on the More (the 3 dots of the top right corner)

file preview

@jesmrec jesmrec modified the milestone: 0.1.0 Sep 27, 2018
@michaelstingl
Copy link
Contributor

michaelstingl commented Oct 17, 2018

I opened an individual issue for "Send a file to other applications": #130

Is this related to #112 too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants