Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppSettings: Passcode lock #25

Closed
8 tasks
jesmrec opened this issue Apr 10, 2018 · 8 comments
Closed
8 tasks

AppSettings: Passcode lock #25

jesmrec opened this issue Apr 10, 2018 · 8 comments
Assignees
Milestone

Comments

@jesmrec
Copy link
Contributor

jesmrec commented Apr 10, 2018

As an user, i want to lock my app with a passcode, so that i can ensure that no one will reach my files

AC:

  • Passcode will have 4 digits.
  • It has to be input twice. If second time does not match the first one, error displayed
  • Possibility to cancel.
  • To remove the passcode, is a must to enter the code
  • Passcode always asked to enter the app
  • Passcode always asked from Files App / 3rd party
  • Set a time after asking the passcode, in which the passcode will not be asked
  • QA
@javiergonzper
Copy link
Contributor

javiergonzper commented May 3, 2018

I am working on the design of the passcode using the current Theme styles

screen shot 2018-05-03 at 14 57 44

screen shot 2018-05-03 at 14 57 57

I hope you like it 😄 (@michaelstingl @felix-schwarz)

@theScrabi
Copy link

theScrabi commented May 7, 2018

@javiergonzper I honestly don't like it. I don't know much about the iPhone design guidelines, but I'm pretty sure this input field does not align with them.

I set up an alternative design. Please tell me what you think of it:

antyeyecancer_white antyeyecancer_black

@jesmrec
Copy link
Contributor Author

jesmrec commented May 7, 2018

@michaelstingl @felix-schwarz @pablocarmu

  • round buttons vs square buttons
  • separate digits vs all digits together

one question: why are used custom buttons instead of the built-in keyboard?

i like round buttons, but also i would rather all digits together.

@michaelstingl
Copy link
Contributor

Examples from other apps:
#3 (comment)

@theScrabi
Copy link

theScrabi commented May 7, 2018

one question: why are used custom buttons instead of the built-in keyboard?

Android app uses keyboard as well.

i like round buttons, but also i would rather all digits together.

Android app has separate input fields for each digit. I think it better that way.

@michaelstingl
Copy link
Contributor

This is the native (iOS 11) look and feel:

- 4-digit numeric 6-digit numeric Custom numeric
Lock screen 2018-05-07 17 11 59 2018-05-07 17 14 59 2018-05-07 17 18 57
Settings screen 2018-05-07 17 12 25 2018-05-07 17 13 05 2018-05-07 17 13 37

@javiergonzper
Copy link
Contributor

Android app has separate input fields for each digit. I think it better that way.

I did all digits together because it could be parametrizable.
let numberDigitsPasscode = 4
Right now we use a 4 digits passcode but maybe in the future we will need a 6 digits (or more) and we just have to change that value.

About the round buttons. My idea was use round buttons but when I apply the OC button styles with the corners I liked it and because of that I let them as you see.

I used the numbers because is the way that the user unlock his iPhone every time. The design with the keyboard of the "Settings" it is aligned with all the "Settings" inteface.

The design that I made it is just now developed:

screen shot 2018-05-08 at 08 19 29

screen shot 2018-05-08 at 08 19 45

@javiergonzper javiergonzper self-assigned this May 9, 2018
@jesmrec
Copy link
Contributor Author

jesmrec commented Jun 5, 2018

Already done.

@jesmrec jesmrec closed this as completed Jun 5, 2018
@jesmrec jesmrec added this to the 0.1.0 milestone Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants