jQuery Core 1.9 Upgrade Guide

[felixheidecke]

jQuery Core 1.9 Upgrade Guide

Changes of Note in jQuery 1.9
See the full upgrade guide at jquery.com

Removed

Minor

.data()

• /js/impersonate.js

.parents()

• /js/impersonate.js

.attr()

• /js/settings-admin.js

.insertBefore()

• /js/impersonate_logout.js

.insertAfter()

• /js/impersonate.js

[sharidas]

Created PR #114, as its required to show impersonate icon.
Also applied the changes mentioned at owncloud/core#31739 (comment).
Below are the tests conducted:

• login as admin user
• created 3 users user1, user2, user3
• enabled impersonate
• Navigated to user management page
• Impersonate icon appeared for user1, user2 and user3.
• created a group group1 and added users user1 and user2 to the group. user1 and user3 are the group admin for group1
• Whitelisted the group group1 in the Settings -> User Authentication page.
• Now tried to impersonate user1 successfully. Was able to see impersonate icon only for user2.
• Now tried to impersonate user2. Didn't allowed further impersonation. Expected behavior.
• Logged out and reached back to admin.
• Logged in as user3 and was able to see impersonate icon for user1 and user2.

[sharidas]

This works as expected. Provided we would have to merge the change:

• Removing the extra '+' character from handlebar #114

and will have to bring change as mentioned in owncloud/core#31739 (comment)

[PVince81]

the change was merged, anything else ?

[PVince81]

regarding owncloud/core#31739 (comment), please test against stable10 instead if possible

[PVince81]

@sharidas please tick the checkboxes accordingly for things you verified / fixed

[sharidas]

Yes other than owncloud/core#31739 (comment), from the impersonate apps perspective nothing blocks.

Closing this ticket as #114 is merged.