Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] new config.php setting with files_primary_s3 #675

Closed
12 tasks
jnweiger opened this issue Oct 6, 2022 · 4 comments · Fixed by #704
Closed
12 tasks

[QA] new config.php setting with files_primary_s3 #675

jnweiger opened this issue Oct 6, 2022 · 4 comments · Fixed by #704
Assignees

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Oct 6, 2022

WHAT Needs to be Documented?

'concurrency' is new in:

'objectstore' => [
        'class' => getenv('OWNCLOUD_OBJECTSTORE_CLASS'),
        'arguments' => [
          'bucket' => getenv('OWNCLOUD_OBJECTSTORE_BUCKET'),
          'autocreate' => getenv('OWNCLOUD_OBJECTSTORE_AUTOCREATE'),
          'part_size' => 52428800,
          'concurrency' => 4,   // <---------------

WHERE Does This Need To Be Documented (Link)?

config sample and whereever files primary s3 is discussed.

WHY Should This Change Be Made?

New in release 1.4.0
owncloud/files_primary_s3#605

(Optional) What Type Of Content Change Is This?

  • New Content Addition
  • Old Content Deprecation
  • Existing Content Simplification
  • Bug Fix to Existing Content

(Optional) Which Manual Does This Relate To?

  • Admin Manual
  • Developer Manual
  • User Manual
  • Android
  • iOS
  • Branded Clients
  • Desktop Client
  • Other
@jnweiger
Copy link
Contributor Author

jnweiger commented Nov 2, 2022

@mmattel @EParzefall release of 1.4.0 is done. Ping?

@mmattel
Copy link
Contributor

mmattel commented Nov 2, 2022

Location for documentation at: https://doc.owncloud.com/server/10.11/admin_manual/configuration/files/external_storage/s3_compatible_object_storage_as_primary.html

No generic config sample content present

To be decided where part_size and concurrency can be applied to the various vendor samples.

@jnweiger
Copy link
Contributor Author

jnweiger commented Nov 2, 2022

Studying the code, I am pretty certain, that both part_size and concurrency are generic arguments, that can be used with any backend.
The way the arguments are constructed I believe that unknown arguments are harmless in any case.

But, I am afraid the the implemenation is not even correct -> opening owncloud/files_primary_s3#624

@jnweiger
Copy link
Contributor Author

jnweiger commented Nov 2, 2022

According to https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/s3-multipart-upload.html

concurrency defaults to 5 ,
part_size defaults to 5242880 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants