Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share sheet improvements (external sharing) #37558

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

ChrisEdS
Copy link
Contributor

@ChrisEdS ChrisEdS commented Jun 18, 2020

Description

To make the view of public links look syncron to the view of internal links I created this PR.

This PR contains:

  • Color of the separator line has the same color
  • The padding of the icons has been enlarged
  • A background color was inserted
  • The padding of the content was increased on the left and right

Related Issue

Motivation and Context

To make the view of public links look syncron to the view of internal links

How Has This Been Tested?

  • Manually tested in Firefox and Chrome

Screenshots:

Before After
Screenshot 2020-06-19 at 00 59 19 Screenshot 2020-06-19 at 00 55 06

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ChrisEdS ChrisEdS requested review from phil-davis and pmaier1 June 18, 2020 23:06
@ChrisEdS ChrisEdS self-assigned this Jun 18, 2020
@update-docs

This comment has been minimized.

@ChrisEdS ChrisEdS force-pushed the public-link-improvements branch from fad4f30 to 19a3d8b Compare June 18, 2020 23:10
@ChrisEdS ChrisEdS force-pushed the public-link-improvements branch from 19a3d8b to 9f50662 Compare June 18, 2020 23:23
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #37558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37558   +/-   ##
=========================================
  Coverage     64.66%   64.66%           
  Complexity    19343    19343           
=========================================
  Files          1279     1279           
  Lines         75600    75600           
  Branches       1333     1333           
=========================================
  Hits          48885    48885           
  Misses        26323    26323           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.83% <ø> (ø) 19343.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b2901...9f50662. Read the comment docs.

@phil-davis
Copy link
Contributor

phil-davis commented Jun 19, 2020

Looks consistent now:
Shares-internal
Shares-public-link

Note: When a share is with a user that has a long display name, or a group that has a long name, then the name automagically drops down under the avatar icon.

For a public link with a long description, that does not happen. But that was also the previous behavior, not something new with this PR. If it is easy to adjust, then that behavior could also be made consistent in a next PR @ChrisEdS

@phil-davis phil-davis merged commit dc3878b into master Jun 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the public-link-improvements branch June 19, 2020 03:25
@ChrisEdS
Copy link
Contributor Author

For a public link with a long description, that does not happen. But that was also the previous behavior, not something new with this PR. If it is easy to adjust, then that behavior could also be made consistent in a next PR

Yes, that was what I thought. I will have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants