Hide add to your OC at the public page when sending shares is not all…

[VicDeo]

…owed by admin

Description

When Allow users on this server to send shares to other servers is unchecked at the Settings->Admin-Sharing there should be no 'Add to your ownCloud' button
Bonus: switch to EventDispatcher as #31944 allows it

Related Issue

• Fixes https://github.com/owncloud/enterprise/issues/3291

How Has This Been Tested?

1. Create a public link

2. Tick Settings->Admin-Sharing Allow users on this server to send shares to other servers

3. open the public link in another browser
   Expected: 'Add to your ownCloud' at the public page

4. Create a public link

5. Untick Settings->Admin-Sharing Allow users on this server to send shares to other servers

6. open the public link in another browser
   Expected: There is NO 'Add to your ownCloud' at the public page

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[codecov]

Codecov Report

Merging #37232 into master will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master   #37232      +/-   ##
============================================
+ Coverage     64.51%   64.52%   +0.01%     
  Complexity    19155    19155              
============================================
  Files          1267     1266       -1     
  Lines         74911    74912       +1     
  Branches       1331     1331              
============================================
+ Hits          48329    48340      +11     
+ Misses        26190    26180      -10     
  Partials        392      392              

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.68% <75.00%> (+0.01%)	19155.00 <0.00> (ø)

Impacted Files	Coverage Δ	Complexity Δ
apps/federatedfilesharing/appinfo/app.php	0.00% <ø> (ø)	0.00 <0.00> (ø)
...s/federatedfilesharing/lib/AppInfo/Application.php	48.22% <75.00%> (+6.62%)	9.00 <0.00> (+1.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa6a1e...997a5f4. Read the comment docs.

[phil-davis]

I created issue #37264 to create some acceptance tests for this button existing or not.
If those get done quickly (tomorrow morning) then they can be added to this PR, otherwise if this PR gets merged first then we will add them as a separate PR.

[phil-davis]

LGTM and works - from a QA/testing POV the acceptance tests demostrate that.
Someone else can approve the detail of the code changes.

[phil-davis]

@VicDeo there were acceptance tests here, and now they have disappeared.

[VicDeo]

@phil-davis oops...I didn't pull before rebasing :(

[phil-davis]

All the code is there now.

[VicDeo]

can't merge - codecov stalled :(

[phil-davis]

codecov/patch result has been not coming many times in recent days. I will submit a result...