[stable10] Make acceptance test function getUserDisplayName more robust #31756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
changed the title
phil-davis
force-pushed
the
stable10-robust-getUserDisplayName
branch
from
3d1f17d to
66bead1
Compare
individual-it
approved these changes
Jun 13, 2018
This was referenced Jun 13, 2018
Signed-off-by: Phil Davis <[email protected]>
phil-davis
force-pushed
the
stable10-robust-getUserDisplayName
branch
from
66bead1 to
eb0e142
Compare
Codecov Report
@@ Coverage Diff @@
## stable10 #31756 +/- ##
===========================================
Coverage 62.36% 62.36%
Complexity 18562 18562
===========================================
Files 1210 1210
Lines 72638 72638
Branches 1273 1273
===========================================
Hits 45298 45298
Misses 26960 26960
Partials 380 380
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #31755
Issue #31747
would be good to get this in for 10.0.9 since it helps minimize the ways app acceptance tests can break core acceptance test code.