OCS endpoint to list remote shares #19386

rullzer · 2015-09-26T08:07:04Z

Required for #9098

Move OCS endpoint ../remote_shares -> ../pending_shares
Introduce new endpoint ../remote_shares that allows listing of incoming remote shares.

@nickvergessen since you wrote the original ../remote_shares stuff are you fine with this?

I'm not really happy with this. But as stated in #9098 (comment) this is the cleanest hack I can think of. Comments?

CC: @cmonteroluque @DeepDiver1975

phil-davis · 2015-09-26T12:19:09Z

apps/files_sharing/api/remote.php

+		$shareInfo = $externalManager->getShare($params['id']);
+
+		if ($shareInfo === false) {
+			return new \OC_OCS_Result(null, 404, 'share does not exists');


s/exists/exist/

nickvergessen · 2015-09-26T19:19:32Z

Maybe remote_shares/pending or do want to use the same endpoint for normal shares in the future?

This needs a PR to fix the URLs in the Pyoc client

rullzer · 2015-09-28T19:11:14Z

Maybe remote_shares/pending or do want to use the same endpoint for normal shares in the future?

Possible for sharing 2.0 yes.

DeepDiver1975 · 2015-09-28T21:08:38Z

Hmmm ... do we really want to change the behavior of already existing public routes?

This is a no go from my perspective - but maybe I missed something.

rullzer · 2015-09-29T05:27:50Z

Hmmm ... do we really want to change the behavior of already existing public routes?

This is a no go from my perspective - but maybe I missed something.

This route was introduced in 8.2. So it is not yet officially released.

DeepDiver1975 · 2015-09-29T07:25:16Z

THX. Fine then

nickvergessen · 2015-09-29T07:41:50Z

apps/files_sharing/lib/external/manager.php

 		$getShare = $this->connection->prepare('
-			SELECT `remote`, `remote_id`, `share_token`, `name`
+			SELECT *


do we want to expose all of the data?
Thinking about password and share_token, I'm not sure they should be leaked like that?

So I agree we should limit what we show. But we also show * in the listing of pending shares.. https://github.com/owncloud/core/blob/master/apps/files_sharing/lib/external/manager.php#L400-L430

So this doesn't introduce anything new.

okay fine by me then

MorrisJobke · 2015-10-01T11:33:04Z

@rullzer Ready to review or not?

rullzer · 2015-10-01T11:35:36Z

@MorrisJobke not yet. I think I need to add some stuff. For #19501 to work properly.

nickvergessen · 2015-10-01T11:59:40Z

btw while preparing a patch for the PyoC Client to change the URL, I realised we can't reuse the same endpoint for remote and normal shares! 💣
The problem is that they have a different unique id. For remote shares we need to accept oc_share_remote.id for normal shares oc_share.id So they can not reuse the same endpoint.

rullzer · 2015-10-01T12:11:47Z

@nickvergessen warg... unique id's are needed then indeed...

rullzer · 2015-10-01T12:26:32Z

@nickvergessen I guess this is then the most logical solution.

rullzer · 2015-10-01T14:13:18Z

Ok extra info added.. do now you actually know something about the remote shares.

Review time.

CC: @nickvergessen @MorrisJobke @DeepDiver1975

* list incoming remote shares at 'remote_shares' * get per share info at 'remote_shares/<ID>' * delete remote share with a DELETE to 'remote_shares/<ID>'

Since we need a unique id to accept/reject shares for now we keep the pending shares under remote_shares. * remote_shares/pending lists pending shares * PUT/DELETE to remote_shares/pending/<ID> will accept/reject the share

The data from the share_external is not to much. Thus we enrich this data with info from the filecache. This allows endpoints using this to actually show usefull information. The filecache might not be up to date but that is a sacrifice we need to make in terms of speed. Else the number of remote PROPFINDS grows lineary with the number of remote shares wich will make this endpoint practically unusable.

rullzer · 2015-10-02T06:23:34Z

Ok cleaned up a bit more so we return a little less cluttered stuff.

rullzer · 2015-10-02T06:27:20Z

OCI failure seems unrelated.

nickvergessen · 2015-10-02T07:07:42Z

Didn't test, but looks good. 👍

PVince81 · 2015-10-02T07:09:44Z

Works 👍

I get the JS code will need to be adjusted later.

nickvergessen · 2015-10-02T07:10:50Z

PyOC patch owncloud/pyocclient#122

rullzer · 2015-10-02T07:16:28Z

I get the JS code will need to be adjusted later.

@PVince81 Already done in #19514
But I did not want to have 1 huge PR.

PVince81 · 2015-10-02T07:16:35Z

Ah yes, the JS code update is here #19514

OCS endpoint to list remote shares

carlaschroder · 2015-10-02T15:44:29Z

@rullzer Is this only for 8.2?

nickvergessen · 2015-10-02T16:25:56Z

yes

carlaschroder · 2015-10-02T16:52:03Z

thanks @nickvergessen

rullzer added 2 - Developing feature:federated-cloud-sharing dev:ocs labels Sep 26, 2015

rullzer added this to the 8.2-current milestone Sep 26, 2015

rullzer mentioned this pull request Sep 26, 2015

Display remote shares in "Shared with you" section #9098

Closed

phil-davis reviewed Sep 26, 2015
View reviewed changes

rullzer force-pushed the ocs_shareapi_extenstion branch from 9eb6858 to 8a9cec6 Compare September 28, 2015 19:12

nickvergessen reviewed Sep 29, 2015
View reviewed changes

rullzer force-pushed the ocs_shareapi_extenstion branch from 8a9cec6 to 9073b71 Compare October 1, 2015 07:03

rullzer added 3 - To Review 2 - Developing and removed 2 - Developing 3 - To Review labels Oct 1, 2015

rullzer mentioned this pull request Oct 1, 2015

Start to show remote shares in shared with you section #19501

Closed

4 tasks

rullzer force-pushed the ocs_shareapi_extenstion branch from 9073b71 to 0e95eb6 Compare October 1, 2015 12:25

rullzer added 3 - To Review and removed 2 - Developing labels Oct 1, 2015

rullzer mentioned this pull request Oct 1, 2015

List remote shares in shared with you #19514

Merged

5 tasks

rullzer force-pushed the ocs_shareapi_extenstion branch from 41e48b5 to 7477fa7 Compare October 1, 2015 15:21

rullzer added 4 commits October 2, 2015 07:39

Move OCS endpoint ../remote_share to ../pending_shares

4a62021

Added '../remote_shares' endpoint

7310c41

* list incoming remote shares at 'remote_shares' * get per share info at 'remote_shares/<ID>' * delete remote share with a DELETE to 'remote_shares/<ID>'

Made routes remote_shares only again

0d30099

Since we need a unique id to accept/reject shares for now we keep the pending shares under remote_shares. * remote_shares/pending lists pending shares * PUT/DELETE to remote_shares/pending/<ID> will accept/reject the share

rullzer force-pushed the ocs_shareapi_extenstion branch from 7477fa7 to 7ecd15d Compare October 2, 2015 05:53

Do not return unneeded info

c924b67

rullzer force-pushed the ocs_shareapi_extenstion branch from 7ecd15d to c924b67 Compare October 2, 2015 06:11

nickvergessen mentioned this pull request Oct 2, 2015

Adjust the pending remote share URLs owncloud/pyocclient#122

Merged

nickvergessen added 4 - To release and removed 3 - To Review labels Oct 2, 2015

DeepDiver1975 added a commit that referenced this pull request Oct 2, 2015

Merge pull request #19386 from owncloud/ocs_shareapi_extenstion

daf9a63

OCS endpoint to list remote shares

DeepDiver1975 merged commit daf9a63 into master Oct 2, 2015

DeepDiver1975 deleted the ocs_shareapi_extenstion branch October 2, 2015 10:13

carlaschroder mentioned this pull request Oct 2, 2015

federated shares appear in shared with you owncloud-archive/documentation#1719

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCS endpoint to list remote shares #19386

OCS endpoint to list remote shares #19386

rullzer commented Sep 26, 2015

phil-davis Sep 26, 2015

nickvergessen commented Sep 26, 2015

rullzer commented Sep 28, 2015

DeepDiver1975 commented Sep 28, 2015

rullzer commented Sep 29, 2015

DeepDiver1975 commented Sep 29, 2015

nickvergessen Sep 29, 2015

rullzer Oct 1, 2015

nickvergessen Oct 1, 2015

MorrisJobke commented Oct 1, 2015

rullzer commented Oct 1, 2015

nickvergessen commented Oct 1, 2015

rullzer commented Oct 1, 2015

rullzer commented Oct 1, 2015

rullzer commented Oct 1, 2015

rullzer commented Oct 2, 2015

rullzer commented Oct 2, 2015

nickvergessen commented Oct 2, 2015

PVince81 commented Oct 2, 2015

nickvergessen commented Oct 2, 2015

rullzer commented Oct 2, 2015

PVince81 commented Oct 2, 2015

carlaschroder commented Oct 2, 2015

nickvergessen commented Oct 2, 2015

carlaschroder commented Oct 2, 2015

OCS endpoint to list remote shares #19386

OCS endpoint to list remote shares #19386

Conversation

rullzer commented Sep 26, 2015

phil-davis Sep 26, 2015

Choose a reason for hiding this comment

nickvergessen commented Sep 26, 2015

rullzer commented Sep 28, 2015

DeepDiver1975 commented Sep 28, 2015

rullzer commented Sep 29, 2015

DeepDiver1975 commented Sep 29, 2015

nickvergessen Sep 29, 2015

Choose a reason for hiding this comment

rullzer Oct 1, 2015

Choose a reason for hiding this comment

nickvergessen Oct 1, 2015

Choose a reason for hiding this comment

MorrisJobke commented Oct 1, 2015

rullzer commented Oct 1, 2015

nickvergessen commented Oct 1, 2015

rullzer commented Oct 1, 2015

rullzer commented Oct 1, 2015

rullzer commented Oct 1, 2015

rullzer commented Oct 2, 2015

rullzer commented Oct 2, 2015

nickvergessen commented Oct 2, 2015

PVince81 commented Oct 2, 2015

nickvergessen commented Oct 2, 2015

rullzer commented Oct 2, 2015

PVince81 commented Oct 2, 2015

carlaschroder commented Oct 2, 2015

nickvergessen commented Oct 2, 2015

carlaschroder commented Oct 2, 2015