Ajaxify user list for files external stable6 #10576

butonic · 2014-08-21T13:26:27Z

backport of #8507 to stable6 as separate PR because it introduces the select2 library

ghost · 2014-08-21T14:55:39Z

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/6833/

LukasReschke · 2014-09-04T11:16:42Z

Same as #10558 (comment):

3rdparty matches upstream
Permission checks are in place
No XSS and CSRF
Seems to work for me.

=> 👍

blizzz · 2014-09-05T08:23:38Z

apps/files_external/settings.php

 $tmpl = new OCP\Template('files_external', 'settings');
 $tmpl->assign('isAdminPage', true);
 $tmpl->assign('mounts', OC_Mount_Config::getSystemMountPoints());
 $tmpl->assign('backends', OC_Mount_Config::getBackends());
-$tmpl->assign('groups', OC_Group::getGroups());
-$tmpl->assign('users', OCP\User::getUsers());
 $tmpl->assign('userDisplayNames', OC_User::getDisplayNames());


this line needs to get removed (as it is in the original PR).

blizzz · 2014-09-05T08:36:47Z

with my last commit 👍 someone wants to doublecheck me? @PVince81

PVince81 · 2014-09-05T09:04:38Z

Do we really want to backport this big change that introduces a new library to stable6 ? @karlitschek please confirm

ghost · 2014-09-05T09:31:35Z

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/7106/

karlitschek · 2014-09-05T09:54:29Z

@blizzz @DeepDiver1975 and @PVince81 what are your opinions?
Unfortunately this is a quite grave problem if you have a lot of users.

blizzz · 2014-09-05T10:11:14Z

Upon further testing, i saw another glitch:

adding a second external storage, all users applied to the first one disappear (only in the GUI, stays intact)

About the backport in general:

Apparently it is not possible to save it with the methods available in a reasonable amount of time and effort. The 3rd party lib is only added to files_external just as are all other code changes. It makes sense a to assign someone to do more intensive testing (inlcuding having LDAP users). OTOH, we already backported it to OC 7.

PVince81 · 2014-09-05T15:15:53Z

@blizzz cannot reproduce on master with non-LDAP users. Do you see it there ??
Will try stable7.
Maybe that issue is specific to stable6 ?
We should raise a separate ticket for that and get it fixed on all affected branches.

blizzz · 2014-09-05T16:12:48Z

No, on master everything was fine, I only saw it on s6. Did not test s7 about it, good thing to do.

butonic · 2014-09-08T12:02:21Z

@blizzz I also cannot reproduce the glitch of users disappearing in the GUI in stable6. Which browser? Did you reload the admin settings? I see the users flickering when adding a new external mount point, but they reappear immediately (ff & chrome).

blizzz · 2014-09-15T09:09:41Z

FF 32. Yes, I reloaded and tried again, it was reproducible.

ghost · 2014-10-06T08:15:22Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng/50/

…tion for files_external, fixes #7499

scrutinizer-notifier · 2014-10-13T20:10:53Z

The inspection completed: 3 new issues, 4 updated code elements

ghost · 2014-10-15T09:18:52Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/125/
💣 Test FAILed. 💣

butonic · 2014-10-16T14:36:50Z

@owncloud-bot retest this please

ghost · 2014-10-16T16:22:56Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/481/

Build result: FAILURE

GitHub pull request #10576 of commit 2107915 automatically merged.Building remotely on vm-slave-02 (SLAVE) in workspace /var/jenkins/workspace/pull-request-analyser-ng-simple@32 > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/10576/merge^{commit} # timeout=10Checking out Revision 15135d8c610ef2d6ef7d97d42ac4f98a8b266075 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 15135d8c610ef2d6ef7d97d42ac4f98a8b266075 > git rev-list 7d8283dbea1f018c6d1523a854ac0bcc168e5044 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02Configuration pull-request-analyser-ng-simple » vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 35 second
💣 Test FAILed. 💣

LukasReschke · 2014-10-16T20:54:09Z

@owncloud-bot Retest this please.

ghost · 2014-10-16T21:34:12Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/515/

Build result: FAILURE

GitHub pull request #10576 of commit 2107915 automatically merged.Building remotely on vm-slave-02 (SLAVE) in workspace /var/jenkins/workspace/pull-request-analyser-ng-simple@2 > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/10576/merge^{commit} # timeout=10Checking out Revision 15135d8c610ef2d6ef7d97d42ac4f98a8b266075 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 15135d8c610ef2d6ef7d97d42ac4f98a8b266075 > git rev-list d324eea120b43175efa4ee6bc384fe1d40d34626 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02Configuration pull-request-analyser-ng-simple » vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 12 second
💣 Test FAILed. 💣

DeepDiver1975 · 2014-10-16T21:39:40Z

Jenkins is failing because there are no js unit test results

🚀 Test PASSed. 🚀

butonic · 2014-10-17T07:25:53Z

@PVince81 @blizzz good to go?

blizzz · 2014-10-17T08:49:14Z

👍

PVince81 · 2014-10-17T09:11:40Z

Had a quick try with LDAP and it seems to work fine 👍

PVince81 · 2014-10-17T09:12:36Z

@karlitschek is there still room in 6.0.6 for this backport ? If yes, please click "Merge pull request".
Thanks.

…xternal_stable6 Ajaxify user list for files external stable6

butonic added 5 - To review labels Aug 21, 2014

butonic added this to the 2014-sprint-02-current milestone Aug 21, 2014

butonic self-assigned this Aug 21, 2014

craigpg modified the milestones: 2014-sprint-03-next, 2014-sprint-02-current Sep 2, 2014

LukasReschke mentioned this pull request Sep 4, 2014

Ajaxify user list for files external stable7 #10558

Merged

This was referenced Sep 5, 2014

Ajaxify user list for files external #8507

Merged

admin page pulls in all groups at once, can cause long loading time #9014

Closed

blizzz reviewed Sep 5, 2014
View reviewed changes

craigpg modified the milestones: 2014-sprint-04-current, 2014-sprint-03 Sep 15, 2014

LukasReschke added 2 - Developing and removed 3 - To Review labels Sep 17, 2014

craigpg modified the milestones: 2014-sprint-05-current, 2014-sprint-04 Sep 29, 2014

craigpg modified the milestones: 2014-sprint-06-current, 2014-sprint-05 Oct 12, 2014

butonic and others added 5 commits October 13, 2014 17:18

add select2 to app specific thirdparty

564d28b

replace chosen with select2 to provide ajaxified user and group selec…

5af5bd5

…tion for files_external, fixes #7499

fix deletion of shares

cb74d8a

no need to load display names

abc2aad

fix flickering users

2107915

butonic force-pushed the ajaxify_user_list_for_files_external_stable6 branch from 31ae00f to 2107915 Compare October 13, 2014 15:49

butonic mentioned this pull request Oct 13, 2014

fix flickering users in files external #11550

Merged

karlitschek added a commit that referenced this pull request Oct 18, 2014

Merge pull request #10576 from owncloud/ajaxify_user_list_for_files_e…

de8c624

…xternal_stable6 Ajaxify user list for files external stable6

karlitschek merged commit de8c624 into stable6 Oct 18, 2014

LukasReschke deleted the ajaxify_user_list_for_files_external_stable6 branch October 20, 2014 07:14

blizzz mentioned this pull request Jan 30, 2015

External Storage available user GUI issue #13781

Closed

lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ajaxify user list for files external stable6 #10576

Ajaxify user list for files external stable6 #10576

butonic commented Aug 21, 2014

ghost commented Aug 21, 2014

LukasReschke commented Sep 4, 2014

blizzz Sep 5, 2014

blizzz commented Sep 5, 2014

PVince81 commented Sep 5, 2014

ghost commented Sep 5, 2014

karlitschek commented Sep 5, 2014

blizzz commented Sep 5, 2014

PVince81 commented Sep 5, 2014

blizzz commented Sep 5, 2014

butonic commented Sep 8, 2014

blizzz commented Sep 15, 2014

ghost commented Oct 6, 2014

scrutinizer-notifier commented Oct 13, 2014

ghost commented Oct 15, 2014

butonic commented Oct 16, 2014

ghost commented Oct 16, 2014

LukasReschke commented Oct 16, 2014

ghost commented Oct 16, 2014

DeepDiver1975 commented Oct 16, 2014

butonic commented Oct 17, 2014

blizzz commented Oct 17, 2014

PVince81 commented Oct 17, 2014

PVince81 commented Oct 17, 2014

Ajaxify user list for files external stable6 #10576

Ajaxify user list for files external stable6 #10576

Conversation

butonic commented Aug 21, 2014

ghost commented Aug 21, 2014

LukasReschke commented Sep 4, 2014

blizzz Sep 5, 2014

Choose a reason for hiding this comment

blizzz commented Sep 5, 2014

PVince81 commented Sep 5, 2014

ghost commented Sep 5, 2014

karlitschek commented Sep 5, 2014

blizzz commented Sep 5, 2014

PVince81 commented Sep 5, 2014

blizzz commented Sep 5, 2014

butonic commented Sep 8, 2014

blizzz commented Sep 15, 2014

ghost commented Oct 6, 2014

scrutinizer-notifier commented Oct 13, 2014

ghost commented Oct 15, 2014

butonic commented Oct 16, 2014

ghost commented Oct 16, 2014

Build result: FAILURE

LukasReschke commented Oct 16, 2014

ghost commented Oct 16, 2014

Build result: FAILURE

DeepDiver1975 commented Oct 16, 2014

butonic commented Oct 17, 2014

blizzz commented Oct 17, 2014

PVince81 commented Oct 17, 2014

PVince81 commented Oct 17, 2014