-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajaxify user list for files external stable7 #10558
Ajaxify user list for files external stable7 #10558
Conversation
…tion for files_external, fixes #7499 remove minified select2 js show avatars for users, simpler results remove unneeded users and groups from settings template fix css, escape user and group names
The inspection completed: 6 new issues, 1 updated code elements |
🚀 Test Passed. 🚀 |
@karlitschek @craigpg please confirm this backport to stable7. |
Exactly. Please wait until next week after 7.0.2 is out. |
Had a quick test with 300 users and it seems to work fine 👍 Would be cool if @ser72 could also help testing this 😄 |
🚀 Test Passed. 🚀 |
Please review this backport @blizzz @LukasReschke |
=> 👍 |
…xternal_stable7 Ajaxify user list for files external stable7
Stable6 backport is still pending review: #10576 |
@@ -46,8 +47,6 @@ | |||
$tmpl->assign('mounts', OC_Mount_Config::getSystemMountPoints()); | |||
$tmpl->assign('backends', $backends); | |||
$tmpl->assign('personal_backends', $personal_backends); | |||
$tmpl->assign('groups', OC_Group::getGroups()); | |||
$tmpl->assign('users', OCP\User::getUsers()); | |||
$tmpl->assign('userDisplayNames', OC_User::getDisplayNames()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was removed in the original PR and should not be here either… will do a PR for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backport of #8507 to stable7 as separate PR because it introduces the select2 library