Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to mime type list #7574

Closed
mophilly opened this issue Mar 5, 2014 · 10 comments
Closed

Add to mime type list #7574

mophilly opened this issue Mar 5, 2014 · 10 comments

Comments

@mophilly
Copy link

mophilly commented Mar 5, 2014

We have encountered many errors, mostly from lucene, about two file types used in our projects.

Omnis Studio library files with the extension .lbr
I believe these can be identified as application/octet-stream

OmniGraffle documents are a bundle similar to Apple .app bundles. The extension is .graffle
These might be identified as application/zip

How to submit these for inclusion in core?

@PVince81
Copy link
Contributor

PVince81 commented Mar 5, 2014

@mophilly you can add these in lib/private/mimetypes.list.php on your side to see whether it works for you, then submit a pull request with the change (are you familiar with git?)

Are you sure these files don't have a better and more specific mime type names ?

@mophilly
Copy link
Author

mophilly commented Mar 5, 2014

@PVince81 Thank you for the quick and useful response.

I will do as you suggest. If it works, I will dig into the git manuals to submit a pull request. BTW, we are running 5.0.13 at the moment. Is it advisable to upgrade to 6.0.x before moving forward on this?

I am not sure if the mime type declarations I posted are the best choice. I plan to send a note to the vendor of each to see what they say.

@mophilly
Copy link
Author

mophilly commented Mar 5, 2014

I found corrolating posts in SVN and GIT forums for OmniGraffe files. I haven't a reply from TigerLogic about the Omnis Studio files yet.

I modified mimetypes.list.php as follows:
Omnis Studio library
'lbr' => 'application/octet-stream'
OmniGraffle files
'graffle' => 'application/octet-stream'

Watching the log entries as the team uses the service.

@PVince81
Copy link
Contributor

PVince81 commented Mar 7, 2014

@mophilly one thing I don't understand is why do you need this change at all ?
I thought that ownCloud was returning 'application/octet-stream' for unknown mime types anyway ?
What is the benefit for you to add these ?

@PVince81
Copy link
Contributor

PVince81 commented Mar 7, 2014

I'm referring to ownCloud 6 actually where mime type is based on file extension.
I just remembered that ownCloud 5 (which I suppose you are using) is detecting mime types using the "file" command, which might return different results in your case ?

@mophilly
Copy link
Author

mophilly commented Mar 7, 2014

@PVince81 yes, we are using ownCloud 5 at the moment; considering the upgrade to 6. I don't know whether ownCloud 5 uses the "file" command.

The behavior that started this inquiry was adding certain files to the shared directory were, or seem to be, causing faults in the log. I theorized it may be the complex structure of the files. E.g. omniGraffle files are "bundles" that are really folders with a special flag and the folder contains a variety of xml files and directories. The folder needs to be treated as file otherwise some bits seem to be lost and the resulting file cannot be opened by the app.

@mophilly
Copy link
Author

The change I put in is either working or is benign and/or the latest update resolved the issue. The files in question seem to be transferring properly.

@PVince81
Copy link
Contributor

Are you saying that no change is needed in 6.0.2 ? If you did add some useful mime types it would be good if we could put them into the project so it might benefit other users.

@mophilly
Copy link
Author

I will check again.
We haven't made the move to v6 yet. I updated to last v5; will make the move soon.
Also, I had not added the mime types after reading your comment about the default being 'application/octet-stream'. I assumed (perhaps wrongly) that one of the client releases may have helped.

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants