Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: ability to exclude external storage mounts from being synced by sync client #7234

Closed
mmattel opened this issue Feb 17, 2014 · 13 comments

Comments

@mmattel
Copy link
Contributor

mmattel commented Feb 17, 2014

During the tests with mirall (desktop sync client), I saw that you have the ability to sync all possible "mount points" you have. Not only the personal one (home) but also those who are assigned to you. Because I have mount points with capacities >2TB, I immediatly recognized that this will become problematic for many reasons.

Possible reasons to exclude mounts from beeing synced:

  1. Capacity limitations
  2. Mounts to work with but you want to implement a no sync ability (single download would be still possible = harden misuse)
  3. Mounts which are set read only
  4. Shared folders
  5. Double synced like dropbox (dropbox can use a lot of space...)
  6. ...

In particular, the ability to exclude should be a must for an administrator who creates mounts and assignes them to users/groups ect. The other cases are to be discussed.

There are two aspects:
a. core ... provide the ability to exclude mount points from beeing synced
b. mirall ... exclude the marked mount points from the sync list presented

It is of course a question if we want to differenciate the ability to sync based on the mount itself and/or refine further on the user/group. This question targets core only and not mirall.

@PVince81
Copy link
Contributor

Note that you can create a folder on the server and only sync that one. In the desktop sync client you can pick that one to be synced instead of the whole ownCloud.
You won't get the "/Shared" folder or mount points that are in the root in that case.

@mmattel
Copy link
Contributor Author

mmattel commented Feb 17, 2014

I know the ability to chose a folder from the mirall client side. My reqest disables this ability from the OC admin side! By that, excluded folders cant be selected on the client side to be synced. You only know in the OC webgui the size of what you could sync.
I have also tested if you can select shared folders to be synced and you can, also in the root!

Here is the mirall folder selector, root view of the adminuser. All mountpoints are external.
mirall mountpoints root

Here is the mirall folder selector, root view of the testuser who got shares assigned from the admin. The folder "Shared" (here is a bug I will file next) is a root mount point from admin shared to testuser and "Bilder iPhone" which is a subfolder from a root mount point shared from admin to testuser
mirall mountpoints testuser

You see all of this is possible, the client can select right now what ever he has got assigned, external mount points either self set or assigned and shared folders. Not good. Therefore my request.

@jancborchardt
Copy link
Member

It seems this is a duplicate of owncloud/client#100, or would better be solved by implementing what is described there. What do you think?

@Aesculapius
Copy link

I think this would be an immensely useful feature! (and has to be seen seperate of issue 100 which looks at the user side.
For me, I include a mount point for users in the "backup" user-group, that points to the backup-folder of their account. This folder contains incremental backups - every 4 hours - using hardlinks. So it really doesn't eat that much space on the server, but if clients start syncing these folders, they turn into terabytes of harddrive space!

So being able as an admin to exclude specific external storage shares from syncing, would be a great feature I think.
Also, I'd like to see an option to also exclude external mount points from being indexed by owncloud, as this also is of no use in case of backup folders and only slows things down. (there is no need to search these folders or anything - you'd just need to have access to them via the webinterface).

@PVince81
Copy link
Contributor

PVince81 commented Apr 8, 2015

If the exclusion is only a "soft" exclusion, one idea would be to have the server return a special WebDAV attribute on the folders that should not be synced, for example "oc:nosync". When the sync client sees this attribute, it would have to skip that folder.
Then in the external storage mount options add an option "Exclude from sync" and make it so that the attribute "oc:nosync" is returned for such mount points.

@RobinMcCorkell
Copy link
Member

The thing is, the user should always be able to override an automatic decision, if they so wish. An admin can suggest that the user doesn't sync a directory, but if the user really wants to synchronise it then they should be able to. I think a way of pushing defaults to the client (that can be overridden) is a better way of solving this than hard-disallowing synchronisation of certain directories. -> #7956

@mmattel
Copy link
Contributor Author

mmattel commented Apr 8, 2015

@PVince81 👍 Admin driven, the user can only sync what is allowed by the precense or abscense of a particular attribute.

@Xenopathic 👎 I disagree. An admin ALWAYS overrides a user decision (or whish), that´s what an admin is for. Having a huge or sensitive datastore that is beeing able to be synced based on a user decision is a no-go. Admin decisions are usually not democratic...

@hameno
Copy link

hameno commented May 5, 2016

Please implement this, I cannot use external storage as my users would never know how to do this themselves (+ I explicitly want to prevent this, as our share is just too big)

@mmattel mmattel changed the title Feature Request: ability to exclude external storage mounts from being synced by mirall Feature Request: ability to exclude external storage mounts from being synced by sync client Jun 3, 2016
@PVince81
Copy link
Contributor

PVince81 commented Oct 7, 2016

Add webdav property to tell sync client to not sync an entry: #26311

@guruz
Copy link
Contributor

guruz commented May 11, 2017

This is done in recent client versions.

For rest see #26311

@guruz guruz closed this as completed May 11, 2017
@imthenachoman
Copy link

Can't this be achieved by creating an external storage to specific folders (instead of the root folder) and assigning permissions? Like I share /folder/one and /folder/two instead of /folder.

@mmattel
Copy link
Contributor Author

mmattel commented Jul 27, 2017

...Yes. I agree that there are two cases: soft and hard "do-not-sync"....
#26311 (comment)

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants