Unit tests failing on Ubuntu 20.04 with PHP 7.4 #38348

phil-davis · 2021-01-27T02:57:57Z

Yesterday the owncloudci/php:7.4 docker images was updated to use Ubuntu 20.04 as the base image (was previously Ubuntu 18.04). See PR owncloud-ci/php#128

Now some unit tests are failing. See demonstration in PR #38346

Maybe Ubuntu 20.04 is missing some things that were installed by default in Ubuntu 18.04, or...?

Investigate and fix (or revert the docker image change for now)

The text was updated successfully, but these errors were encountered:

phil-davis · 2021-01-27T03:26:34Z

An example in the nightly CI - files_primary_s3 running the core unit tests with PHP 7.4
https://drone.owncloud.com/owncloud/files_primary_s3/2077/8/7

There were 8 failures:

1) Test\LargeFileHelperGetFileSizeTest::testGetFileSizeViaCurl with data set #0 ('/var/www/owncloud/server/test...em.txt', 446)
Failed asserting that null is identical to 446.

/var/www/owncloud/server/tests/lib/LargeFileHelperGetFileSizeTest.php:53

2) Test\LargeFileHelperGetFileSizeTest::testGetFileSizeViaCurl with data set #1 ('/var/www/owncloud/server/test...2).txt', 446)
Failed asserting that null is identical to 446.

/var/www/owncloud/server/tests/lib/LargeFileHelperGetFileSizeTest.php:53

3) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-68, -77)
Failed asserting that 0.77 matches expected 1.41.

/var/www/owncloud/server/tests/lib/Preview/Provider.php:155
/var/www/owncloud/server/tests/lib/Preview/Provider.php:104

4) Test\Preview\BitmapTest::testGetThumbnail with data set #1 (48, 24)
Failed asserting that 0.77 matches expected 1.41.

/var/www/owncloud/server/tests/lib/Preview/Provider.php:155
/var/www/owncloud/server/tests/lib/Preview/Provider.php:104

5) Test\Preview\BitmapTest::testGetThumbnail with data set #2 (-95, 73)
Failed asserting that 0.77 matches expected 1.41.

/var/www/owncloud/server/tests/lib/Preview/Provider.php:155
/var/www/owncloud/server/tests/lib/Preview/Provider.php:104

6) Test\Preview\BitmapTest::testGetThumbnail with data set #3 (49, -34)
Failed asserting that 0.77 matches expected 1.41.

/var/www/owncloud/server/tests/lib/Preview/Provider.php:155
/var/www/owncloud/server/tests/lib/Preview/Provider.php:104

7) Tests\Core\Templates\TemplatesTest::test403
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">\n
-<html><body><ul><li class="error">\n
-		Access forbidden<br><p class="hint"></p>\n
-</li></ul></body></html>\n
+<html><body><ul>\n
+<li class="error">\n
+		Access forbidden<br>\n
+		<p class="hint"></p>\n
+	</li>\n
+</ul></body></html>\n
 '

/var/www/owncloud/server/tests/lib/TestCase.php:506
/var/www/owncloud/server/tests/lib/TestCase.php:484
/var/www/owncloud/server/tests/Core/Templates/TemplatesTest.php:9

8) Tests\Core\Templates\TemplatesTest::test404
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">\n
-<html><body><ul><li class="error">\n
-			File not found<br><p class="hint">The specified document has not been found on the server.</p>\n
-<p class="hint"><a href="/owncloud/">You can click here to return to ownCloud.</a></p>\n
-		</li></ul></body></html>\n
+<html><body><ul>\n
+<li class="error">\n
+			File not found<br>\n
+			<p class="hint">The specified document has not been found on the server.</p>\n
+			<p class="hint"><a href="/owncloud/">You can click here to return to ownCloud.</a></p>\n
+		</li>\n
+	</ul></body></html>\n
 '

/var/www/owncloud/server/tests/lib/TestCase.php:506
/var/www/owncloud/server/tests/lib/TestCase.php:484
/var/www/owncloud/server/tests/Core/Templates/TemplatesTest.php:16

--

phil-davis · 2021-01-27T07:17:36Z

I have reverted the changes to owncloudci/php:7.4 so that existing CI can be "great again" - PR owncloud-ci/php#129

phil-davis · 2021-01-27T08:19:54Z

PR owncloud-ci/php#130 has created owncloudci/php:7.4-ubuntu20.04 docker image.
I will use that to test the phpunit, Behat, etc tests and get it passing properly before putting Ubuntu 20.04 into the "real" owncloudci/php:7.4 docker image.

VicDeo · 2021-02-02T16:02:59Z

Test\LargeFileHelperGetFileSizeTest::testGetFileSizeViaCurl seems to be a php_curl regression:

# curl -I file:///home/deo/public_html/oc-tmp/tests/data/lorem.txt
Content-Length: 446
Accept-ranges: bytes
Last-Modified: Mon, 17 Jun 2013 07:25:11 GMT

Headers are here. But the script

<?php
$ch = \curl_init("file:///home/deo/public_html/oc-tmp/tests/data/lorem.txt");
\curl_setopt_array(
        $ch,
        [
                CURLOPT_NOBODY => true,
                CURLOPT_RETURNTRANSFER => true,
                CURLOPT_HEADER => true
        ]
);
$data = \curl_exec($ch);
\curl_close($ch);
var_dump($data);

returns no headers:
string(0) ""

I'm pretty sure file protocol is enabled - after removing CURLOPT_NOBODY => true, the file content is dumped.

and it does return headers when the resource is changed from
file:///home/deo/public_html/oc-tmp/tests/data/lorem.txt into e.g. http://localhost/oc/core/js/login.js?v=988646cb965e528fd57397e8b9b4468f

So CLI curl returns headers for the file protocol while php curl extendsion doesn't.

dpakach · 2021-06-09T03:47:23Z

@phil-davis this one fails for me even with php 7.3 when running locally, so seems like the problem is with ubuntu 20.04.

phil-davis · 2022-02-21T05:15:16Z

Note: this needs doing in the next month or two, because it will be good to run all CI with Ubuntu 20.04 before PHP 8.* gets progress.

phil-davis · 2022-05-09T06:44:30Z

So CLI curl returns headers for the file protocol while php curl extension doesn't.

I found this which reports the same problem:

https://stackoverflow.com/questions/59709625/curlfile-scheme-not-returns-headers-in-php-7-3

I am starting an Ubuntu 18.04 VM so that I can try it with PHP 7.4 etc.

Update:

This cURL code to get the headers works on Ubuntu 18.04 with any of the PHP that I tried - 7.2 7.3 and 7.4

Exactly the same code fails to return any header information on Ubuntu 20.04 with any version of PHP - I tried 5.6 7.0 7.1 7.2 7.3 7.4 8.0 8.1. So I guess that there is something different about libcurl.

On my systems:
Ubuntu 18.04

$ curl-config --version
libcurl 7.58.0

Ubuntu 20.04

$ curl-config --version
libcurl 7.68.0

This issue looks like where the regressions was reported: curl/curl#3083
And fixed in commit curl/curl@e50a200
But that commit seems to be included in curl 7.62 - so 7.68 should have the fix - what is going on???

phil-davis · 2022-05-10T08:55:19Z

I have confirmed that CURLOPT_HEADER for file:// works on Ubuntu 18.04 (in a VM that I installed)
It does not work on Ubuntu 20.04 or Ubuntu 22.04.

I found a way to use CURLOPT_HEADERFUNCTION and that works on all Ubuntu 18.04 20.04 and 22.04 - see PR #40065

phil-davis · 2022-05-10T09:12:33Z

PRs #40054 #40059 and #40065 fix all the issues so that the code, tests and CI all pass on both Ubuntu 18.04 and Ubuntu 20.04.

After those are reviewed and merged, then I will make another PR to run PHP tests with 7.4-ubuntu20.04, and it should pass.

phil-davis · 2022-05-19T04:58:53Z

Currently blocked waiting for core 10.10.0 final release. Then I can merge the waiting PRs and continue...

kiranparajuli589 · 2022-05-23T05:47:56Z

@phil-davis owncloud core 10.10.0 has been released. can we move forward on this?

phil-davis · 2022-05-23T05:51:58Z

Now blocked by #40054 - carddav and caldav tests need python2, but Ubuntu 22.04 has python3 by default.

@xoxys has said that he will update those test suites so that they run with python3: #40054 (comment)

The PHP unit tests in master now pass on Ubuntu 22.04

phil-davis · 2022-06-07T10:23:40Z

PR #40054 was merged. It explicitly uses python2 in the caldav/carddav test scripts. We will stay with that for now.

The next step is testing with Ubuntu 22.04 - see PR #40123

After that is passing, I will think about what to do for regular CI. Maybe we will wait until a few other infrastructure things have happened - for example, the guzzle v7 update and dropping PHP 7.3 support. Then we can decide what to do about the test matrix for PHP 7.4.

kiranparajuli589 · 2022-10-14T10:57:47Z

closing. see owncloud/files_primary_s3#613 (comment)

phil-davis added Type:Bug QA:team labels Jan 27, 2021

phil-davis self-assigned this Jan 27, 2021

phil-davis mentioned this issue Jan 27, 2021

[tests-only] Trigger CI #38346

Closed

This was referenced Jan 27, 2021

New core acceptance tests are failing with user-key encryption owncloud/encryption#233

Closed

Revert "Use Ubuntu 20.04 as the base for PHP 7.4" owncloud-ci/php#129

Merged

kiranparajuli589 unassigned phil-davis May 5, 2021

dpakach self-assigned this Jun 9, 2021

This was referenced Jun 10, 2021

[tests-only] Test with docker owncloudci/php:7.4-ubuntu20.04 #38829

Closed

[tests-only Hardcode PHP unit tests to run on php:7.4-ubuntu20.04 #38830

Closed

dpakach removed their assignment Jun 15, 2021

phil-davis mentioned this issue Nov 8, 2021

[tests-only] [full-ci] Run PHP unit tests on php:7.4-ubuntu20.04 #39460

Closed

phil-davis mentioned this issue Apr 22, 2022

[tests-only] Run PHP tests with 7.4-ubuntu20.04 #40006

Closed

11 tasks

This was referenced May 6, 2022

[tests-only] Explicitly use python2 for carddav and caldav tests #40054

Merged

[tests-only] Make TemplatesTest more flexible #40059

Merged

phil-davis mentioned this issue May 10, 2022

Add flexibility to getFileSizeViaCurl #40065

Merged

11 tasks

phil-davis self-assigned this May 19, 2022

phil-davis mentioned this issue Jun 7, 2022

[tests-only] [full-ci] PHP Ubuntu22.04 #40123

Closed

11 tasks

phil-davis mentioned this issue Jun 17, 2022

[tests-only] Run PHP tests with 7.4-ubuntu20.04 #40147

Closed

11 tasks

phil-davis mentioned this issue Jun 27, 2022

[tests-only] Run PHP tests with 7.4-ubuntu20.04 #40172

Closed

11 tasks

phil-davis mentioned this issue Jul 28, 2022

[tests-only] Run PHP tests with 7.4-ubuntu20.04 #40249

Closed

11 tasks

phil-davis mentioned this issue Aug 17, 2022

[tests-only] Run PHP tests with 7.4-ubuntu20.04 #40292

Closed

11 tasks

phil-davis mentioned this issue Sep 21, 2022

[tests-only] Run PHP tests with 7.4-ubuntu20.04 #40385

Closed

11 tasks

kiranparajuli589 mentioned this issue Oct 14, 2022

php unit test fails in nightly owncloud/files_primary_s3#613

Closed

kiranparajuli589 closed this as completed Oct 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unit tests failing on Ubuntu 20.04 with PHP 7.4 #38348

Unit tests failing on Ubuntu 20.04 with PHP 7.4 #38348

phil-davis commented Jan 27, 2021

phil-davis commented Jan 27, 2021

phil-davis commented Jan 27, 2021

phil-davis commented Jan 27, 2021

VicDeo commented Feb 2, 2021 •

edited

Loading

dpakach commented Jun 9, 2021

phil-davis commented Feb 21, 2022

phil-davis commented May 9, 2022 •

edited

Loading

phil-davis commented May 10, 2022

phil-davis commented May 10, 2022

phil-davis commented May 19, 2022

kiranparajuli589 commented May 23, 2022

phil-davis commented May 23, 2022

phil-davis commented Jun 7, 2022

kiranparajuli589 commented Oct 14, 2022

Unit tests failing on Ubuntu 20.04 with PHP 7.4 #38348

Unit tests failing on Ubuntu 20.04 with PHP 7.4 #38348

Comments

phil-davis commented Jan 27, 2021

phil-davis commented Jan 27, 2021

phil-davis commented Jan 27, 2021

phil-davis commented Jan 27, 2021

VicDeo commented Feb 2, 2021 • edited Loading

dpakach commented Jun 9, 2021

phil-davis commented Feb 21, 2022

phil-davis commented May 9, 2022 • edited Loading

phil-davis commented May 10, 2022

phil-davis commented May 10, 2022

phil-davis commented May 19, 2022

kiranparajuli589 commented May 23, 2022

phil-davis commented May 23, 2022

phil-davis commented Jun 7, 2022

kiranparajuli589 commented Oct 14, 2022

VicDeo commented Feb 2, 2021 •

edited

Loading

phil-davis commented May 9, 2022 •

edited

Loading