Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share_folder can be shared #36241

Closed
HanaGemela opened this issue Oct 4, 2019 · 2 comments · Fixed by #36337
Closed

share_folder can be shared #36241

HanaGemela opened this issue Oct 4, 2019 · 2 comments · Fixed by #36337
Assignees
Milestone

Comments

@HanaGemela
Copy link
Contributor

Server: 10.3.0RC1

Steps to recreate:

  1. Add share_folder into config.php
  2. User1 shares a file with User2
  3. User2 deletes the file from their account
  4. User2 shares share_folder

Actual result: share_folder can be shared. Any new files which are added to that folder as newly received shares are not shared to the collaborators. But new files can be added via public links. This is confusing

Expected result: Sharing of share_folder is not allowed

@HanaGemela HanaGemela added this to the QA milestone Oct 4, 2019
@phil-davis
Copy link
Contributor

I expect that users have been able to do this sort of thing in all core versions (since whenever share_folder was introduced)

So IMO this is not a regression, but it is a good idea to prevent users sharing the special folder share_folder

@karakayasemi
Copy link
Contributor

share permission is removed for share_folder and its parent folders by #36337.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants