Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sabre uri #36189

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Bump sabre uri #36189

merged 1 commit into from
Sep 16, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 12, 2019

Description

  - Updating sabre/uri (2.1.2 => 2.1.3): Loading from cache

https://github.com/sabre-io/uri/releases/tag/2.1.3

The change looks a good thing, maybe for if you try to install your ownCloud in an Apache root 0 so that you are trying to access it at https://myserver.com/0/index.php - probably nobody tried to do that!

Motivation and Context

Get latest dependencies.
IMO we may as well have current dependencies when making an RC (when they do not break anything!) - there seems no point delivering a release candidate that has known "old" dependencies.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #36189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36189   +/-   ##
=======================================
  Coverage   54.01%   54.01%           
=======================================
  Files          63       63           
  Lines        7404     7404           
  Branches     1309     1309           
=======================================
  Hits         3999     3999           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0fd679...ab6864d. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #36189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36189   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7408     7408           
  Branches     1309     1309           
=======================================
  Hits         4001     4001           
  Misses       3021     3021           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28e53d9...f19e602. Read the comment docs.

@phil-davis
Copy link
Contributor Author

I rebased just now so that CI runs here with the sabre/uri bump, on top of the sabre/http bump that was merged this morning.

@DeepDiver1975 DeepDiver1975 merged commit 9d7b5e0 into master Sep 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the bump-sabre-uri branch September 16, 2019 07:32
@micbar micbar mentioned this pull request Sep 16, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - To Review dependencies php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants