Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block listing children of upload-only folder on GET request #36119

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Aug 29, 2019

Description

Block listing children of upload-only folder on GET request

Related Issue

Motivation and Context

It should not be possible to read files in upload-only folder

How Has This Been Tested?

Steps to reproduce
share a folder as "Upload Only" as public link
download a file from that folder using the new webdav public link api

curl --silent \
http://owncloud/remote.php/dav/public-files/Upload_Folder_Share_Token/Path_To_the_File \
-H 'X-Requested-With:XMLHttpRequest' \
-H "Range:bytes=0-150" \
-X GET

Expected behaviour

download should not be possible (404)

Actual behaviour

download is possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #36119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36119   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98922f1...dc9a72f. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #36119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36119   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa17f5...cbd4705. Read the comment docs.

Copy link
Member

@jvillafanez jvillafanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, assuming it works and tests pass

@PVince81 PVince81 merged commit f1528fd into master Aug 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-36076 branch August 30, 2019 13:26
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new public webdav] public can download file from upload-only folder if filename is known
4 participants