Update the minimum required Node engine version to 8.15.0 #36033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eca2e63 updated the minimum required jsdoc version to "~3.6.2". This version requires a minimum node version of 8.15.0 (https://github.com/jsdoc/jsdoc/blob/master/package.json#L48). However, the commit didn't update the minimum node engine version in build/package.json. While node 8.15.0 is a relatively old version now, if it's not available, when running make install-nodejs-deps, the user will encounter the following error: error [email protected]: The engine "node" is incompatible with this module. Expected version ">=8.15.0". Got "8.13.0" error Found incompatible module info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. make: *** [Makefile:166: build/node_modules] Error 1 This change prevents this from occurring.
voroyam
approved these changes
Aug 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #36033 +/- ##
=======================================
Coverage 53.85% 53.85%
=======================================
Files 63 63
Lines 7377 7377
Branches 1301 1301
=======================================
Hits 3973 3973
Misses 3019 3019
Partials 385 385
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #36033 +/- ##
=======================================
Coverage 53.85% 53.85%
=======================================
Files 63 63
Lines 7377 7377
Branches 1301 1301
=======================================
Hits 3973 3973
Misses 3019 3019
Partials 385 385
Continue to review full report at Codecov.
|
delete-merged-branch
bot
deleted the
update-minimum-required-node-engine-version
branch
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the minimum required Node engine version to 8.15.0.
Related Issue
Motivation and Context
4f9a936, through dependabot[bot], updated the minimum required jsdoc version to
~3.6.2from~3.5.5. Version 3.6.2 requires a minimum node version of 8.15.0. However, the commit didn't update the minimum node engine version inbuild/package.json.While node 8.15.0 is a relatively old version now, (the currently recommended versions are 10.16.2 and 12.8.0), if at least that version's not available, then when running
make install-nodejs-deps, the user will encounter the following error:How Has This Been Tested?
I encountered this error as the version of node that I had installed at the time (via npm), when running
makewas 8.13.0. After I updated to the latest stable version (12.8.0) the error is no longer encountered, and all of the JavaScript dependencies are successfully installed.Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: