Roles API + allow setting permissions via share attribues

[DeepDiver1975]

Description

The roles api allows clients to ask the server for supported roles.
Currently only roles for public links are implemented.
Apps can listen to the event dispatcher and add their own roles.

The current concept does not reflect any capability for apps to change roles (core or from other apps)

Here is an example on how to submit permissions via the attributes property

Related Issue

• refs https://github.com/owncloud/enterprise/issues/3473

How Has This Been Tested?

• 🤷‍♂️

Screenshots (if appropriate):

curl http://deepdiver:8080/ocs/v1.php/cloud/roles?format=json  -u admin -H 'Accept-Language: de-DE' | json_pp 
Enter host password for user 'admin':
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1301  100  1301    0     0   1848      0 --:--:-- --:--:-- --:--:--  1845
{
   "ocs" : {
      "data" : [
         {
            "id" : "core.viewer",
            "context" : {
               "publicLinks" : {
                  "order" : 10,
                  "permissions" : {
                     "ownCloud" : {
                        "read" : true
                     }
                  },
                  "displayDescription" : "Empfänger können Inhalte sehen und herunterladen.",
                  "resourceTypes" : [
                     "*"
                  ]
               }
            },
            "displayName" : "Herunterladen / Ansehen"
         },
         {
            "displayName" : "Herunterladen / Ansehen / Bearbeiten",
            "context" : {
               "publicLinks" : {
                  "displayDescription" : "Empfänger können Inhalte sehen, herunterladen und bearbeiten.",
                  "resourceTypes" : [
                     "httpd/unix-directory"
                  ],
                  "order" : 20,
                  "permissions" : {
                     "ownCloud" : {
                        "update" : true,
                        "delete" : true,
                        "read" : true,
                        "create" : true
                     }
                  }
               }
            },
            "id" : "core.editor"
         },
         {
            "context" : {
               "publicLinks" : {
                  "order" : 30,
                  "permissions" : {
                     "ownCloud" : {
                        "read" : true,
                        "create" : true
                     }
                  },
                  "displayDescription" : "Empfänger können Inhalte sehen, herunterladen und hochladen.",
                  "resourceTypes" : [
                     "httpd/unix-directory"
                  ]
               }
            },
            "id" : "core.contributor",
            "displayName" : "Herunterladen / Ansehen / Hochladen"
         },
         {
            "displayName" : "Nur Hochladen (File Drop)",
            "context" : {
               "publicLinks" : {
                  "order" : 40,
                  "permissions" : {
                     "ownCloud" : {
                        "create" : true
                     }
                  },
                  "displayDescription" : "Von mehreren Empfängern Dateien empfangen, ohne den Inhalt des Ordners preiszugeben.",
                  "resourceTypes" : [
                     "httpd/unix-directory"
                  ]
               }
            },
            "id" : "core.uploader"
         }
      ],
      "meta" : {
         "status" : "ok",
         "message" : "OK",
         "statuscode" : 100,
         "totalitems" : "",
         "itemsperpage" : ""
      }
   }
}

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #36024 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #36024   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385

Flag	Coverage Δ
#javascript	53.85% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9898824...e0c449b. Read the comment docs.

[codecov]

Codecov Report

Merging #36024 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #36024   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385

Flag	Coverage Δ
#javascript	53.85% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d711e...2ef190a. Read the comment docs.

[michaelstingl]

@felix-schwarz @hosy @TheOneRing Could you have a look?

[felix-schwarz]

The JSON and Accept-Language-support checks all the boxes from https://github.com/owncloud/enterprise/issues/2742 that are needed by the iOS client. Looks good to me. 👍

[PVince81]

See minor comments.

I'm missing unit tests for RolesController, at least to check that a few of the roles are returned (does not need to be 100% match).
Also need to test that the AddRoleEvent contents will actually appear in the roles API result.

[PVince81]

seems the automatic formatter did not decide to add spaces between the "." for concatenation (wenn schon denn schon!)

same for some other reformatting below

[PVince81]

Looks good to me 👍

[settermjd]

@DeepDiver1975, do you have a code example of how apps can listen to the event dispatcher and add their own roles?

[DeepDiver1975]

@DeepDiver1975, do you have a code example of how apps can listen to the event dispatcher and add their own roles?

No app is currently using this - I suggest to leave this undocumented for the time being.
We will extend this - and then really need this - as soon as we are implementing the roles api for collaboration.

I'll let you know as soon as we are at this point. THX

[settermjd]

Thanks for the clarification.