[stable10] Backport of Renaming and adding new options for public link #34983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Renaming View/Download/Upload to View/Download/Edit. 2) Adding new option View/Download/Upload. So if user wants to give provide all permissions, View/Download/Edit option could be opted. If the user wants to have an option where no edit and delete to be granted for link shared, the View/Download/Upload could be used. Signed-off-by: Sujith H <[email protected]>
…nd no overwrite feature Adding acceptance test for new upload option added for creating public links. This new option would create public links which would help users to download, upload files or folders. Signed-off-by: Sujith H <[email protected]>
|
Original PR #34687 |
12 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #34983 +/- ##
==============================================
+ Coverage 64.24% 64.24% +<.01%
- Complexity 19993 19994 +1
==============================================
Files 1281 1281
Lines 76648 76650 +2
Branches 1307 1307
==============================================
+ Hits 49243 49245 +2
Misses 27024 27024
Partials 381 381
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #34983 +/- ##
==============================================
+ Coverage 64.24% 64.24% +<.01%
- Complexity 19993 19994 +1
==============================================
Files 1281 1281
Lines 76648 76650 +2
Branches 1307 1307
==============================================
+ Hits 49243 49245 +2
Misses 27024 27024
Partials 381 381
Continue to review full report at Codecov.
|
This was referenced Apr 15, 2019
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames and adds an option in the public link share dialog. The
View/Download/Uploadis now renamed toView/Download/Edit. So if the user wants to create a link which would let others to create, edit, upload and delete in the public link thenView/Download/Editshould be selected.The new option
View/Download/Uploadhas lesser permission. When a public link with this option is created, the user could create folder(s), no delete option is available.Related Issue
Motivation and Context
View/Download/UploadtoView/Download/Editin the public link share creation dialog.View/Download/Uploadwith minimal permission. Removed edit and delete option.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: