Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Add a command to poll incoming federated shares for updates #34933

Merged
merged 3 commits into from
Apr 1, 2019

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Mar 29, 2019

Description

Backport of #34903

Allow manually poll federated share updates and update the storage root
to help the sync client properly detect federated share updates

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  1. setup two OC instances oc1 and oc2
  2. create a federated share from user@oc1 to user@oc2 with a deep nested folder structure
  3. Accept the share by user@oc2
  4. Setup a desktop client for user@oc2, let it sync the data
  5. update the share by user@oc1 (e.g by uploading something into /really/deeply/nested/folder)
  6. wait for the client - nothing is synced
  7. run php occ incomingShares:sync
  8. wait a bit - the changes is synced

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@VicDeo VicDeo added this to the development milestone Mar 29, 2019
@VicDeo VicDeo self-assigned this Mar 29, 2019
@VicDeo VicDeo changed the title Stable10 cmd to sync fedshares [stable10] Add a command to poll incoming federated shares for updates Mar 29, 2019
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

PVince81 commented Apr 1, 2019

(please always pick some reviewers!)

@PVince81 PVince81 merged commit 82fbe64 into stable10 Apr 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-cmd-to-sync-fedshares branch April 1, 2019 06:41
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants