Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] files:scan --group and --groups options #34754

Merged
merged 3 commits into from
Mar 14, 2019

Conversation

phil-davis
Copy link
Contributor

Description

Backport last 2 commits from #31719
Backport #34753

This effectively adds files:scan --group in addition to the existing files:scan --groups option.
See explanation in #34753 (comment)

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis force-pushed the stable10-files-scan-group-groups branch from f4d283d to 19fdc56 Compare March 12, 2019 16:10
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #34754 into stable10 will decrease coverage by 19.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #34754       +/-   ##
===============================================
- Coverage       64.04%   45.03%   -19.02%     
===============================================
  Files            1278      116     -1162     
  Lines           75838    11465    -64373     
  Branches         1291     1291               
===============================================
- Hits            48572     5163    -43409     
+ Misses          26887     5923    -20964     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 30.64% <ø> (-34.56%) 0 <ø> (-19258)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1153 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca9f4e...19fdc56. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #34754 into stable10 will increase coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34754      +/-   ##
==============================================
+ Coverage       64.04%   64.04%   +<.01%     
  Complexity      19258    19258              
==============================================
  Files            1278     1278              
  Lines           75838    75845       +7     
  Branches         1291     1291              
==============================================
+ Hits            48572    48578       +6     
- Misses          26887    26888       +1     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.2% <85.71%> (ø) 19258 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Command/Scan.php 72.18% <85.71%> (+0.34%) 62 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca9f4e...19fdc56. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit c7fe8ca into stable10 Mar 14, 2019
@PVince81 PVince81 deleted the stable10-files-scan-group-groups branch March 14, 2019 09:11
@phil-davis
Copy link
Contributor Author

Docs issue owncloud/docs#742 and docs PR owncloud/docs#743

@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants