Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] throw exception when .htaccess file is not writable #34461

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

individual-it
Copy link
Member

backport of #32230

@individual-it individual-it force-pushed the stable10-showErrorWhenHtaccessNotWritable branch from 3b292b5 to 767d318 Compare February 12, 2019 03:49
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #34461 into stable10 will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34461      +/-   ##
==============================================
+ Coverage       63.55%   63.57%   +0.02%     
- Complexity      19143    19146       +3     
==============================================
  Files            1265     1265              
  Lines           75307    75314       +7     
  Branches         1291     1291              
==============================================
+ Hits            47858    47884      +26     
+ Misses          27069    27050      -19     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.67% <77.77%> (+0.03%) 19146 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Setup.php 27.6% <77.77%> (+11.24%) 52 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e061087...767d318. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #34461 into stable10 will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34461      +/-   ##
==============================================
+ Coverage       63.55%   63.57%   +0.02%     
- Complexity      19143    19146       +3     
==============================================
  Files            1265     1265              
  Lines           75307    75314       +7     
  Branches         1291     1291              
==============================================
+ Hits            47858    47884      +26     
+ Misses          27069    27050      -19     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.67% <77.77%> (+0.03%) 19146 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Setup.php 27.6% <77.77%> (+11.24%) 52 <0> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e061087...767d318. Read the comment docs.

@phil-davis phil-davis closed this Feb 12, 2019
@phil-davis phil-davis reopened this Feb 12, 2019
@phil-davis phil-davis merged commit 87b391b into stable10 Feb 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-showErrorWhenHtaccessNotWritable branch February 12, 2019 11:02
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants