Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language of internal sharing email notification should be in recipient language #33397

Closed
plastikschnitzer opened this issue Nov 2, 2018 · 5 comments · Fixed by #34144
Closed
Assignees
Milestone

Comments

@plastikschnitzer
Copy link

plastikschnitzer commented Nov 2, 2018

Steps to reproduce

  1. Share folder/file to another internal ownCloud user
  2. Notify user by email

Expected behaviour

The ownCloud user should get the notification email in his language

Actual behaviour

The email is sent in the language from the user who shared the folder, but this not necessarily the language of the email recipient.

Server configuration

ownCloud version: 10.0.10

Updated from an older ownCloud or fresh install: updated

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #7417 (Email Notification in Language), #12608 (Shared file notifications), #4499 (Shared File Notifications), #5593 (Possibility to add email address in user management), and #5719 (sending share email link fails).

@plastikschnitzer
Copy link
Author

The new feature in ownCloud 10.0.10 is for external shares, not for shares to an internal ownCloud user.

If you share files/directories with an internal ownCloud user and send an email notification as mentioned above in my bug report, the email language is in the language of the owner, not the recipient.

@plastikschnitzer
Copy link
Author

The release notes from 10.0.10 states that my desired behavior is the case for internal shares, but this is not the case, its broken. Please test my setup!

Maybe it was even broken with this new "set language for guest shares" feature because it sets the sharing email language by default to the owner language – for guest shares. Not sure if this causes the problem for internal shares, its just an idea how it could have happened.

@plastikschnitzer plastikschnitzer changed the title Language of sharing email notification should be in users language Language of internal sharing email notification should be in recipient language Nov 6, 2018
@PVince81
Copy link
Contributor

also observed recently as @mrow4a clicked "notify by mail" and I received the email in Polish while my user is set to English.

@PVince81 PVince81 added this to the backlog milestone Jan 11, 2019
@PVince81 PVince81 added the p3-medium Normal priority label Jan 11, 2019
@pmaier1
Copy link
Contributor

pmaier1 commented Jan 11, 2019

In contrast to external shares oC knows the language of internal share recipients. For other notifications (e.g. Pending Shares) the configured language of the recipient is used. That should be made consistent here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants