Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previews-thumbnails get out-of-sync when edited by sharer and sharee #31855

Closed
phil-davis opened this issue Jun 21, 2018 · 6 comments · Fixed by #39203
Closed

Previews-thumbnails get out-of-sync when edited by sharer and sharee #31855

phil-davis opened this issue Jun 21, 2018 · 6 comments · Fixed by #39203

Comments

@phil-davis
Copy link
Contributor

Steps to reproduce

  1. as "user1" create folder "test" and in it put "testfile.txt" with content "owner" - thumbnail says "owner" - good
  2. share folder "test" with "user2"
  3. as "user2", edit "testfile.txt" and put content "user2 text"
  • thumbnail displayed to "user2" is not updated, it still says "owner"
  1. login as "user1" - the thumbnail displays "user2 text" - good
  2. login as "user2" again - look at the thumbnail of the file
  • thumbnail displayed to "user2" is not updated, it still says "owner"
  1. login as "user1" again, edit the file and put content "user1 text" - thumbnail is updated - good
  2. login as "user2" again - look at the thumbnail of the file
  • thumbnail displayed to "user2" is not updated, it still says "owner"

Expected behaviour

The share receiver "user2" should always see a preview-thumbnail that is in sync with the file content.

Actual behaviour

The share receiver "user2" gets "stuck" with the preview-thumbnail that was generated at the time they first received/looked at the file.

Server configuration

10.0.9RC1 plus PR #31853 (which fixes missing hooks for thumbnail generation in 10.0.9RC1)

10.0.8 as symptoms similar to this, but might be a bit different.

@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 21, 2018

Ideally the thumbnail of a file would be stored only once, in the "file system" of the file owner. Just like the file itself is stored only once, in the "file system" of the file owner.

If the share receiver "user2" is able to write back new content to the file owned by "user1" (even when encryption is happening) then "user2" should be able to also write back new content to the thumbnail owned by "user1" - and actually that seems to be happening because "user1" is seeing the correct updated thumbnail.

Maybe all that is needed is to stop writing a "duplicate" thumbnail in user2's file system?

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #19054 (If thumbnail then large preview in sidebar), #997 (possibility preview and edit docx), #16471 (Can not sync edited remote share file), #7020 (Contact photos only in preview when edited on a client), and #14671 (Thumbnail cache gets deleted after upload from smartphone).

@PVince81 PVince81 added this to the backlog milestone Jun 21, 2018
@PVince81 PVince81 added the p3-medium Normal priority label Jun 21, 2018
@PVince81 PVince81 self-assigned this Jun 27, 2018
@PVince81 PVince81 modified the milestones: backlog, development Jun 27, 2018
@PVince81
Copy link
Contributor

PVince81 commented Jul 6, 2018

Estimate: 0.5-1md

@PVince81 PVince81 assigned DeepDiver1975 and unassigned PVince81 Jul 6, 2018
@DeepDiver1975
Copy link
Member

Concept:

  • store thumbnails by file id in an user independent storage data/thumbnails
  • old thumbnail folders are to be deleted using a repair step/migration step
  • OPTIONAL: new thumbnails can be batch recreated using an occ command

@phpweb
Copy link

phpweb commented Sep 21, 2018

Thank you @phil-davis

When approximately can we have this feature?

@phil-davis
Copy link
Contributor Author

It is a bug to be fixed. It depends on scheduling of the dev team, which is not my area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants