Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to create a read-write public share of a file #31538

Closed
phil-davis opened this issue May 25, 2018 · 4 comments
Closed

Attempt to create a read-write public share of a file #31538

phil-davis opened this issue May 25, 2018 · 4 comments

Comments

@phil-davis
Copy link
Contributor

Steps to reproduce

  1. Run acceptance test tests/acceptance/features/apiSharing-v1/createShare.feature:75
  2. It passes

Expected behaviour

Maybe an attempt to make a public share of a file with read and write permissions should fail with some 4nn HTTP status?

Actual behaviour

The test scenario makes a public share of file welcome.txt with all permissions (read, write, reshare...). The public share creation succeeds and the public share actually just has read permission.

Server configuration

drone CI or local dev environment

See PR #31495 where the test scenario was added.

@phil-davis
Copy link
Contributor Author

@PVince81 @patrickjahns or anybody, does the current behavior seem OK?

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #3949 (File sharing), #3273 (Sharing a single file), #3465 (Sharing files), #5417 (Ghosted shared file), and #20839 (Sharing a file allows you to set create permissions).

@PVince81 PVince81 added this to the maybe some day milestone May 25, 2018
@PVince81
Copy link
Contributor

Considering that we don't support creating public links for files with read-write permissions as we haven't tested the implications in public link page, we should likely block it on API level for now.

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants