Deprecate files API call to set favorites in favor of standard PROPPATCH

[SamuAlfageme]

Setting test.txt as favorite:

Current WebUI's Implementation:

curl -u 'admin:admin' -X POST https://localhost/index.php/apps/files/api/v1/files/test.txt \
  -H 'Content-Type: application/json' \
  -d '{
	"tags": [
		"_$!<Favorite>!$_"
	]
}'

Proposal:

curl -u 'admin:admin' -X PROPPATCH https://localhost/remote.php/dav/files/admin/test.txt \
  -H 'Content-Type: application/xml' \
  -d '<?xml version="1.0" ?>
<d:propertyupdate xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
    <d:set>
    <d:prop>
        <oc:favorite>1</oc:favorite>
    </d:prop>
  </d:set>
</d:propertyupdate>
'

To unset it; make it <oc:favorite>0</oc:favorite> /cc @PVince81 as PROPPATCH advocate

[PVince81]

Oh... I didn't realize we still had the old thing :-/