Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theme-example] Enable only for specific groups ??? #30887

Closed
michaelstingl opened this issue Mar 23, 2018 · 7 comments
Closed

[theme-example] Enable only for specific groups ??? #30887

michaelstingl opened this issue Mar 23, 2018 · 7 comments
Assignees
Labels
bug-analysis feature:theming p2-high Escalation, on top of current planning, release blocker Type:Bug
Milestone

Comments

@michaelstingl
Copy link

michaelstingl commented Mar 23, 2018

settings_-_custom_cloud

@VicDeo Why do we have the checkbox [ ] Enable only for specific groups for themes? I don't remember this in previous versions? Is this useful for themes? Can I have different theme for different groups? What theme is shown on the login page or in public share link? (when no user is logged in)

Or is this a bug? /cc @ChrisEdS

oC 10.0.7

00009167

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #3209 (Theming), #20304 (Allow public routes for group specific enabled apps), #1111 (Enable apps only for specific users/groups), #27995 (Conflict between app type filesystem and app setting Enable only for specific groups), and #3267 (Which groups am I in?).

@VicDeo
Copy link
Member

VicDeo commented Mar 23, 2018

@michaelstingl

Why do we have the checkbox [ ] Enable only for specific groups for themes

Because app type theme is not listed as 'protected' here https://github.com/owncloud/core/blob/master/lib/private/App/AppManager.php#L49-L59

I don't remember this in previous versions

But it doesn't mean that it was not possible with previous versions 😸

Can I have different theme for different groups?

Nope. Enabling two different themes at once was blocked since 10.0.6 or 10.0.7

@michaelstingl
Copy link
Author

@VicDeo Thanks for your explanation!

@PVince81 @pmaier1 I'd vote for adding theme type to the list?

@DeepDiver1975
Copy link
Member

@PVince81 @pmaier1 I'd vote for adding theme type to the list?

👍

@pmaier1
Copy link
Contributor

pmaier1 commented Mar 26, 2018

👍

@PVince81 PVince81 added the p2-high Escalation, on top of current planning, release blocker label Mar 26, 2018
@PVince81 PVince81 added this to the development milestone Mar 26, 2018
@VicDeo VicDeo removed the regression label Mar 26, 2018
@VicDeo
Copy link
Member

VicDeo commented Mar 29, 2018

[ ] Enable only for specific groups will disappear for themes since 10.0.8

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug-analysis feature:theming p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
None yet
Development

No branches or pull requests

6 participants