Importing federated shares produces an error

[tomneedham]

10.0.3.3

Details still coming in.

Wrong constructor arguments here:

core/apps/files_sharing/ajax/external.php

Line 73 in bb71b69

\OC::$server->getNotificationManager(),

Produces log:

Nov 24 11:31:52 owncloud-dev-1 ownCloud[6827]: {index} Exception: 
{"Exception":"TypeError","Message":"Argument 4 passed to 
OCA\\Files_Sharing\\External\\Manager::__construct() must implement 
interface OCP\\Notification\\IManager, instance of OC\\HTTPHelper given, 
called in \/var\/www\/owncloud\/apps\/files_sharing\/ajax\/external.php 
on line 75","Code":0,"Trace":"#0 
\/var\/www\/owncloud\/apps\/files_sharing\/ajax\/external.php(75): 
OCA\\Files_Sharing\\External\\Manager->__construct(Object(OC\\DB\\Connection), 
Object(OC\\Files\\Mount\\Manager), 
Object(OC\\Files\\Storage\\StorageFactory), Object(OC\\HTTPHelper), 
Object(OC\\Notification\\Manager), 
Object(OCA\\FederatedFileSharing\\DiscoveryManager), '0434156')\n#1 
\/var\/www\/owncloud\/lib\/private\/Route\/Route.php(155) : 
runtime-created function(1): require_once('\/var\/www\/ownclo...')\n#2 
[internal function]: __lambda_func()\n#3 
\/var\/www\/owncloud\/lib\/private\/Route\/Router.php(307): 
call_user_func('\\x00lambda_104', Array)\n#4 
\/var\/www\/owncloud\/lib\/base.php(928): 
OC\\Route\\Router->match('\/apps\/files_sha...')\n#5 
\/var\/www\/owncloud\/index.php(56): OC::handleRequest()\n#6 
{main}","File":"\/var\/www\/owncloud\/apps\/files_sharing\/lib\/External\/Manager.php","Line":80} 

[ownclouders]

GitMate.io thinks the contributor most likely able to help you is @PVince81.

[tomneedham]

Can confirm this as an issue on master currently.

1. visit public share
2. enter instance url in 'add to owncloud'
3. accept import of share
4. share should appear
   instead
5. exception in error log

[PVince81]

Likely regression after #28858

[individual-it]

Todo

• write UI tests UI tests to add public link shares to remote server #29860

[individual-it]

reopening because UI tests are missing

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.