Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable10] Fix storing/retrieval for dav properties of non files #29273

Merged
merged 7 commits into from
Oct 18, 2017

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Oct 17, 2017

backport of #29136

Description

  • integration tests for setting properties via old endpoind and getting them via new one and vice versa
  • Use the same CustomPropertiesBackend with old/new endpoint
  • Fix regression in calendar app by storing properties for non-files dav resources into a separate oc_dav_properties table
  • Test with old cards/cals and old endpoint.
  • ✅ Works for files at the old endpoint.
    mapping old dav path -> new dav path needed for oc_dav_properties. Not needed.
    Previous version of backend was not used by remote.php/caldav and remote.php/carddav endpoints

Related Issue

#29047

Motivation and Context

Code deduplication + regression fix

How Has This Been Tested?

  • integration tests
  • proppatching files using tests/TestHelpers/WebDavHelper.php as a library
  • selecting/unselecting calendars in calendar app and checking entries in oc_dav_properties

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VicDeo VicDeo added this to the development milestone Oct 17, 2017
@VicDeo VicDeo self-assigned this Oct 17, 2017
@VicDeo VicDeo added the p1-urgent Critical issue, need to consider hotfix with just that issue label Oct 17, 2017
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 17, 2017

Codecov Report

Merging #29273 into stable10 will increase coverage by 0.08%.
The diff coverage is 76.7%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #29273      +/-   ##
==============================================
+ Coverage       58.38%   58.47%   +0.08%     
+ Complexity      17677    17672       -5     
==============================================
  Files            1056     1058       +2     
  Lines           59243    59233      -10     
==============================================
+ Hits            34590    34636      +46     
+ Misses          24653    24597      -56
Impacted Files Coverage Δ Complexity Δ
...s/dav/appinfo/Migrations/Version20170116170538.php 0% <ø> (ø) 1 <0> (ø) ⬇️
...s/dav/appinfo/Migrations/Version20170202220512.php 0% <ø> (ø) 1 <0> (ø) ⬇️
...s/dav/appinfo/Migrations/Version20170116150538.php 0% <ø> (ø) 21 <0> (ø) ⬇️
...s/dav/appinfo/Migrations/Version20170202213905.php 21.05% <ø> (ø) 12 <0> (ø) ⬇️
...s/dav/appinfo/Migrations/Version20170427182800.php 0% <ø> (ø) 2 <0> (ø) ⬇️
...s/dav/appinfo/Migrations/Version20170927201245.php 0% <0%> (ø) 2 <2> (?)
apps/dav/lib/Server.php 48.33% <0%> (-4.35%) 11 <1> (-5)
apps/dav/lib/Connector/Sabre/ServerFactory.php 94.2% <100%> (ø) 11 <0> (ø) ⬇️
apps/dav/lib/DAV/MiscCustomPropertiesBackend.php 71.15% <71.15%> (ø) 12 <12> (?)
apps/dav/lib/DAV/FileCustomPropertiesBackend.php 90.27% <90.27%> (ø) 16 <16> (?)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b6917...3c2a01f. Read the comment docs.

@PVince81
Copy link
Contributor

@VicDeo please rebase to trigger Jenkins build

@VicDeo
Copy link
Member Author

VicDeo commented Oct 18, 2017

@PVince81 CI is happy, merging.

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - To release p1-urgent Critical issue, need to consider hotfix with just that issue status/STALE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants