Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Remove double quotes from boolean values in status.php output #29271

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Oct 17, 2017

Description

Backport of #29261 to stable10

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 @phil-davis

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@PVince81 PVince81 added this to the development milestone Oct 17, 2017
@PVince81 PVince81 self-assigned this Oct 17, 2017
@PVince81
Copy link
Contributor

Rebased to retrigger Jenkins (it was dead yesterday)

@PVince81 PVince81 merged commit 994a61f into stable10 Oct 18, 2017
@PVince81 PVince81 deleted the stable10-fix_for_29228 branch October 18, 2017 12:23
@codecov
Copy link

codecov bot commented Oct 18, 2017

Codecov Report

Merging #29271 into stable10 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #29271   +/-   ##
===========================================
  Coverage       58.38%   58.38%           
  Complexity      17677    17677           
===========================================
  Files            1056     1056           
  Lines           59243    59243           
===========================================
  Hits            34590    34590           
  Misses          24653    24653
Impacted Files Coverage Δ Complexity Δ
lib/public/Util.php 40.6% <0%> (ø) 68 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b6917...185da80. Read the comment docs.

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants