Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix don show shares you own in "shared with you" #27972

Merged
merged 1 commit into from
May 22, 2017

Conversation

peterprochaska
Copy link
Contributor

Description

added check for not showing shares you own

Related Issue

https://github.com/owncloud/security-tracker/issues/246

Motivation and Context

make ownCloud more secure

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SergioBertolinSG
Copy link
Contributor

👍 Works.

@PVince81
Copy link
Contributor

Code looks good but as I see no change in unit tests I expect a failure will happen

@DeepDiver1975 DeepDiver1975 removed the request for review from rullzer May 22, 2017 10:54
@PVince81
Copy link
Contributor

fantastic

...................
12:59:02 [ERROR] Waited 600 seconds, no response
12:59:02 Kill the docker aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 Makefile:179: recipe for target 'test-php' failed
12:59:02 make: *** [test-php] Error 1
[Pipeline] }

@DeepDiver1975 mind restarting the job ?

1 similar comment
@PVince81
Copy link
Contributor

fantastic

...................
12:59:02 [ERROR] Waited 600 seconds, no response
12:59:02 Kill the docker aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 Makefile:179: recipe for target 'test-php' failed
12:59:02 make: *** [test-php] Error 1
[Pipeline] }

@DeepDiver1975 mind restarting the job ?

@DeepDiver1975
Copy link
Member

restarted

@PVince81 PVince81 merged commit 83a788c into master May 22, 2017
@PVince81 PVince81 deleted the dont-show-shares-you-own-in-sharedwithyou branch May 22, 2017 14:47
@PVince81
Copy link
Contributor

@Peter-Prochaska don't forget to submit a separate PR to add a proper test for this

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants