Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swiftmailer #27897

Merged
merged 1 commit into from
May 16, 2017
Merged

Update swiftmailer #27897

merged 1 commit into from
May 16, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented May 16, 2017

Description

Related Issue

fixes #26886

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81
Copy link
Contributor

missing list of test cases, did you retest emailing ?

@DeepDiver1975
Copy link
Member Author

DeepDiver1975 commented May 16, 2017

missing list of test cases, did you retest emailing ?

is the mailhog integratoin test already in place? I dont have email setup in my dev env .... maybe I should ....

@PVince81
Copy link
Contributor

Mailhog was only quickly added for use in guest apps. No tests were added for core mailing yet.

cc @SergioBertolinSG

@SergioBertolinSG
Copy link
Contributor

Mailhog was only quickly added for use in guest apps. No tests were added for core mailing yet.

Yes that's right, in core it will require to spawn the mailhog container like in guest app and actually write the tests. I guess some of them will require to use the ajax request from the ui, like in guests.

@PVince81
Copy link
Contributor

I suggest quick manual testing for now. Maybe test an activity mail and a guest mail.

@DeepDiver1975
Copy link
Member Author

DeepDiver1975 commented May 16, 2017

Tested

  • password change
  • smtp test email

bildschirmfoto von 2017-05-16 15-34-19

@PVince81 PVince81 merged commit c142369 into master May 16, 2017
@PVince81 PVince81 deleted the update-swift branch May 16, 2017 13:36
@PVince81
Copy link
Contributor

Thanks 👍

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible security issue (CVE-2016-10074) in swiftmailer (3rd party) library
4 participants