-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to restrict share autocomplete to group members #27869
Conversation
👍 Code looks good. |
Tests added. Turns out we already had sharee tests so it was much easier to add new ones. I suggest we merge this. Once @tomneedham rebases #27832 the integration tests will tell whether this still works with his changes. |
When set, the autocomplete only displays user or group results matching the current user's group memberships. Typing a full user or group name not in the result list will still allow sharing with these entries.
527872a
to
1a49ff6
Compare
rebased for CI |
Uh oh |
UH OH!! This fails on master as well 😱 I'll have a look... |
this PR fixes the test issue from master: #27888 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
When set, the autocomplete only displays user or group results matching
the current user's group memberships.
Typing a full user or group name not in the result list will still allow
sharing with these entries.
Related Issue
Fixes #27849
Motivation and Context
See issue
How Has This Been Tested?
When the new option is set:
Screenshots (if appropriate):
Types of changes
Checklist:
TODOs:
@jvillafanez @tomneedham @pmaier1