Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to restrict share autocomplete to group members #27869

Merged
merged 4 commits into from
May 15, 2017

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented May 12, 2017

Description

When set, the autocomplete only displays user or group results matching
the current user's group memberships.

Typing a full user or group name not in the result list will still allow
sharing with these entries.

Related Issue

Fixes #27849

Motivation and Context

See issue

How Has This Been Tested?

When the new option is set:

  • TEST: autocomplete only show current user's user results
  • TEST: autocomplete only show current user's group results
  • TEST: typing full recipient user name not in result list still allows sharing
  • TEST: typing full recipient group name not in result list still allows sharing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

TODOs:

@jvillafanez @tomneedham @pmaier1

@felixboehm
Copy link
Contributor

👍 Code looks good.

@PVince81
Copy link
Contributor Author

Tests added. Turns out we already had sharee tests so it was much easier to add new ones.

I suggest we merge this. Once @tomneedham rebases #27832 the integration tests will tell whether this still works with his changes.

Vincent Petry added 4 commits May 15, 2017 09:23
When set, the autocomplete only displays user or group results matching
the current user's group memberships.

Typing a full user or group name not in the result list will still allow
sharing with these entries.
@PVince81 PVince81 force-pushed the restrict-autocomplete-groups branch from 527872a to 1a49ff6 Compare May 15, 2017 07:24
@PVince81
Copy link
Contributor Author

rebased for CI

@PVince81
Copy link
Contributor Author

Test Result (1 failure )
sharing.Increasing permissions is allowed for owner

11:44:52 /var/lib/jenkins/workspace/owncloud-core_core_PR-27869-PFEZRZD5FK7SZH2ETSWIQLOH5DH7VH6KYURTFPNPUUQEXLM2E42A/tests/integration/features/sharing-v1.feature:1051

Uh oh

@PVince81
Copy link
Contributor Author

UH OH!! This fails on master as well 😱

I'll have a look...

@PVince81
Copy link
Contributor Author

this PR fixes the test issue from master: #27888

@PVince81 PVince81 merged commit 347264c into master May 15, 2017
@PVince81 PVince81 deleted the restrict-autocomplete-groups branch May 15, 2017 19:20
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a sharing option to restrict autocompletion for users in different groups
2 participants