Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Cron settings: support themed radio buttons #27681

Merged
merged 1 commit into from Apr 20, 2017
Merged

Admin Cron settings: support themed radio buttons #27681

merged 1 commit into from Apr 20, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 19, 2017

Because of this, themes can be applied too.

Description

Add class to support the :before CSS part. This will allow theming, and shows the new OC radio buttons.

Related Issue

Unknown

Motivation and Context

Comply with standard. Forgotten part, I guess.

How Has This Been Tested?

Apply commit, watch and see. Tested in OC9 and OC10.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Suggestion

Replace e.g. all
input[type="radio"].radio:checked + label:before
by
input[type="radio"]:checked + label:before
so these edits aren't needed. It's redundant anyway, since all vanilla theming (default OC theming) should be applied to all radio buttons and check boxes.

Because of this, themes can be applied too.
@PVince81
Copy link
Contributor

Fine by me for now, but I'm not sure everyone will think about setting the "radio" class on all new radio elements.

@PVince81 PVince81 merged commit 718d85b into owncloud:master Apr 20, 2017
@ghost
Copy link
Author

ghost commented Apr 24, 2017

Which is why

input[type="radio"].radio:checked + label:before

should be replaced in you big styles.css or input.css by

input[type="radio"]:checked + label:before

And so on.

@ghost ghost deleted the patch-4 branch April 24, 2017 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants