Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "local link" to "private link" #27594

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Rename "local link" to "private link" #27594

merged 1 commit into from
Apr 7, 2017

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Apr 7, 2017

@pmaier1 @felixheidecke please review

private_link

Fixes #27593

@pmaier1
Copy link
Contributor

pmaier1 commented Apr 7, 2017

Great! 👍

@PVince81
Copy link
Contributor Author

PVince81 commented Apr 7, 2017

I find this big block to be a bit heavy, but ok.

If @felixheidecke doesn't object we can merge this.

@pmaier1
Copy link
Contributor

pmaier1 commented Apr 7, 2017

I find this big block to be a bit heavy, but ok.

True. Maybe @felixheidecke comes up with a better idea, otherwise I'm fine with this as it's definitely better than no explanation.

@PVince81
Copy link
Contributor Author

PVince81 commented Apr 7, 2017

I don't think we can add line breaks in a tooltip, so if there is a better way it will like have to be a different revamped UI. I think I'll merge this for now.

@PVince81 PVince81 merged commit cc8cc1a into master Apr 7, 2017
@PVince81 PVince81 deleted the privatelink branch April 7, 2017 09:11
@felixheidecke
Copy link
Contributor

felixheidecke commented Apr 7, 2017

7e419d4a-1b81-11e7-8ec6-fa7ab1b4175f

Still a double wording?! Public-Link people have "access" too but can't use it ;-)
We can only hope people will understand what that really means. If they do is a whole other thing.
I'm fine with it, but it's not optimal.

@pmaier1
Copy link
Contributor

pmaier1 commented Apr 7, 2017

Public-Link people have "access" too but can't use it ;-)

This does not make sense or at least I don't understand it^^

There are two use cases for the private link:

  1. Have a link to a certain file/folder that will stay as it is as long as the file is available (this is why I described it as 'permanent')
  2. Point others to certain files/folders within shares

I'm also not totally happy with it but I don't know how we could make it more clear :/

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change name of 'local/permanent link' to 'private link'
3 participants