-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test all external storages with encryption enabled #23657
Comments
Also cc @Xenopathic @icewind1991 @DeepDiver1975 might be worth to have https://github.com/owncloud/core/tree/0e687993c8afb36876e7d90c229b97b4aaf43b70/apps/files_external/tests adjusted to also run once with encryption enabled. |
cc @schiesbn As discussed |
Edit: Fixed with #23660 |
It would be better to isolate the behaviour that encryption sometimes breaks on, and create a unit test for that behaviour to apply for all storages. That way we keep true to individual unit tests which will make testing quicker and less prone to cross-component failures. |
@jvillafanez can you please help here |
@rperezb @jvillafanez @owncloud/qa I tested all storages except "OpenStack Object Storage", "SMB" and "Sharepoint". Could you give this a test as well? 🚀 |
Sure, I'm building a docker image to test OpenStack (in fact devstack), but it will require a bit of time. I hope the image is mostly ready today and we can test it tomorrow |
@jvillafanez We already have a Docker image - see xenopathic/ceph-keystone |
Setting up devstack Unfortunately I can't make it work using docker. In my case, it complains about network issues trying to work with iptables, specially it doesn't have permissions to add new entries in iptables (I'm not willing to force heavy requirements) The ceph-keystone didn't work for neither @Xenopathic nag me about this next week 😉
I'll use a VM as a fallback. |
❗ |
SMB works fine 👍 |
@jvillafanez Thanks. Let me see what I can do about Sharepoint fail. I have an idea what it could be 💭 |
For sharepoint with encryption, file deletion isn't working, but renaming the file is (with and without the "Use RetryWrapper" patch) |
OpenStack works fine 👍 |
Can we close this and continue in the sharepoint ticket if that's the only one remaining ? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Due to the problems with some external storages in 9.0 with regard to the stream wrapper (which returned less than 8192 bytes) I'm going to manually retest all external storages with encryption enabled as well.
cc @owncloud/qa @rperezb Is there any way that we can come up with some automated way to test them with encryption enabled as well? That would be rocking 🚀
The text was updated successfully, but these errors were encountered: