SMB sync client local rename redownloads after second sync

[PVince81]

Steps

1. Setup a SMB mount as "/smb"
2. Setup desktop client
3. Let it sync
4. Create a local folder "/smb/test" and put a few files inside
5. Let it sync
6. Locally, rename "/smb/test2"
7. Let it sync
8. Wait, let it sync again (second pass)

Expected result

Second pass doesn't do anything

Actual result

Second pass redownloads the contents of "test2", you can see the notification

Note: I also set a favorite flag on one of the files inside and it was kept on rename, so there is no file id change. Probably something wrong with etags/mtimes/update detection.

Versions

ownCloud 8.2.3
Also observed with the new SMB lib on this PR #23363

@icewind1991

[PVince81]

Samba server: samba-4.3.5-2.1.x86_64
All running on the same openSUSE Tumbleweed machine

[PVince81]

Possibly related bug but with worse outcome: #23376

[PVince81]

CC @MorrisJobke in case this popped up in other cases

[PVince81]

Only happens in 8.2.3.
The 9.0.0 version works properly.
Adjusting milestone.

Forgot to mention that this is with owncloud-client-2.1.1-1.1.x86_64

[PVince81]

I tried on 9.0.0 to use the "apps/files_external/lib/smb.php" from v8.2.3 due to minor changes, but it still works fine. So I suspect this has something to do with the library.

Let me try if it still happens after the lib update: #23363

[PVince81]

On stable8.2 even with the library update from #23363, the problem still exists.

This means that the problem is not with files_external's SMB or Icewind/SMB but rather with etag handling. Note that etag propagation has been reworked in 9.0.0 so it is likely that it got fixed that way.

[PVince81]

I tried the same scenario in v8.2.3 with SFTP and there is no redownload.

So it looks like OC <= 8.2.3 requires the storage to do something for rename/etag to work properly. SFTP does it right but SMB does it wrong.

[PVince81]

I also tried WND on stable8.2, and the redownload doesn't happen. So this means WND is doing propertly something that SMB doesn't...

[PVince81]

As this works fine in OC >= 9.0, closing.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.