Primary storage - object store and encryption

[MorrisJobke]

Is the config.sample.php still up to date with the encryption 2.0:

WARNING: The current implementation is incompatible with any app that uses direct file IO and circumvents our virtual filesystem. That includes Encryption and Gallery. Gallery will store thumbnails directly in the filesystem and encryption will cause severe overhead because key files need to be fetched in addition to any requested file.

core/config/config.sample.php

Lines 951 to 955 in b4853f3

	* WARNING: The current implementation is incompatible with any app that uses
	* direct file IO and circumvents our virtual filesystem. That includes
	* Encryption and Gallery. Gallery will store thumbnails directly in the
	* filesystem and encryption will cause severe overhead because key files need
	* to be fetched in addition to any requested file.

And does the encryption stream the content or is it downloaded to the owncloud server, then decrypted and then send out to the client? This would then also effect external storage.

cc @butonic @schiesbn @icewind1991

00004489

[PVince81]

From what I remember, the encryption code has been improved to always go through the View, which somewhat implies that it doesn't access the file system directly. This also happens when handling keys.

So I'd expect that this should now work with encryption.

@schiesbn can you confirm ?

[butonic]

The warning was added because at the time it was not possible to put the keys into a different folder than the rest of the files. Technically, encryption is working with objectstorage, but it would introduce a painful latency on any file access. Now that we can place keys on the local device the situation might have changed. I guess QA needs to reevaluate.

[PVince81]

@owncloud/qa

[settermjd]

Does this require a documentation update?

[PVince81]

Depends whether QA can confirm if object store indeed works fine with encryption (ideally with automated tests)

[PVince81]

Assigning to @SergioBertolinSG to figure out how to automatically test.

Easiest would be to add it to the integration test matrix which now also covers encryption.
Better would be if we could first have integration tests running against dockers, where the docker itself provides that config.

[SergioBertolinSG]

@PVince81, Docker is essential for this one, we need somewhere to connect. ref: https://github.com/owncloud/qa-enterprise/issues/55

[felixboehm]

@SergioBertolinSG What is the blocker to test this?
Is it a blocker for automated tests only?

[SergioBertolinSG]

No blocker at all, automated tests for objectstore are already set up in its repository.

[felixboehm]

Any result? #22058 (comment)

[SergioBertolinSG]

After checking it, objectstore tests are not setup in travis to run using encryption. Currently I'm seeing some issues while running tests locally even without encryption, not sure if there are bugs or my environment is not working fine. I'll have to dedicate some time to figure out what is happening.

Last tests passed of objectstore: https://travis-ci.com/owncloud/objectstore/jobs/67402255

[felixboehm]

Did you also test ownCloud 10 with objectstorage and encryption?

[SergioBertolinSG]

Not myself, not sure if anyone did.

[PVince81]

@felixboehm would move to planned.

@SergioBertolinSG have we gotten further with the object store tests since last time ?

[PVince81]

moving to "planned"

[ownclouders]

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

[ownclouders]

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

[PVince81]

need to retest and verify and adjust the docs accordingly

[SergioBertolinSG]

@PVince81 https://github.com/owncloud/objectstore/issues/55

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.