Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMB storage must throw StorageNotAvailable in specific cases #21219

Closed
PVince81 opened this issue Dec 15, 2015 · 5 comments
Closed

SMB storage must throw StorageNotAvailable in specific cases #21219

PVince81 opened this issue Dec 15, 2015 · 5 comments
Labels
app:files_external enhancement
Milestone
maybe some day

Comments

@PVince81
Copy link
Contributor

PVince81 commented Dec 15, 2015 •
edited by DeepDiver1975
Loading

@icewind1991 @jmaciasportela make the SMB storage throw StorageNotAvailableException in case of timeouts or when the remote server does not identify as a SMB server, or the credentials have changed.

Do not throw it for other exceptions like ForbiddenException.
@PVince81 PVince81 added this to the 9.0-current milestone Dec 15, 2015
@PVince81 PVince81 mentioned this issue Dec 15, 2015
Closed
9 tasks
@PVince81
Copy link
Contributor Author

Not sure if handled by your recent PRs ? @icewind1991

@icewind1991
Copy link
Contributor

No

@ghost ghost modified the milestones: 9.1-next, 9.0-current Feb 22, 2016
@PVince81 PVince81 modified the milestones: 9.1-current, 9.2-next Jun 24, 2016
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 8, 2016

and maybe have a special exception for timeouts as well, as discussed with @jvillafanez recently

@PVince81 PVince81 modified the milestones: backlog, 10.0 Dec 8, 2016
@PVince81
Copy link
Contributor Author

Seems we already throw this in 10.0.4 for some code paths, closing.

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
app:files_external enhancement
Projects
None yet
Milestone
maybe some day
Development

No branches or pull requests
2 participants
@PVince81 @icewind1991