-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Previews sending the mimetype icon have a wrong size #18655
Comments
@oparoz IIRC You modified the mimetype-fallback to use a centered 16x16 icon, right?
We can't scale up the svg, because that would introduce a hard-dependency on imagick. Scaling up the png is not good. This is kind of part of the discussion, whether or not the preview api should return mimetype-icons at all (which it should not IMHO) or if it should just send some error code instead. In the case of an error code, the js should take care of using the svg mime type icon instead. |
Well the problem is, activity app already checks whether the mimetype is supported, to avoid this request. Oh, I just discovered the isAvailable() method, so I can use that, it will take away the blurriness, but still the size is smaller. |
Do I need to fix anything here with the filetype icons? I hope not right, because previously it was generated from the SVG up to 150*150px, right? |
OK, so 3 things need to happen if we want to fix this in 8.2:
|
For mobile apps we prefer error code. Removing MIME icon fallback is fine for us. Thanks for the ping :) |
it looks like we won't be fixing this until 9.0 |
backlog for now, not critical (please tell if you think otherwise) |
Hey, this issue has been closed because the label (This is an automated comment from GitMate.io.) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
http://localhost/index.php/core/preview.png?file=/test.txt&x=150&y=150
Expected
The preview is 150*150 pixels
Actual
The preview is 16*16pixels
Analysis
\OC_Preview::getMimeIcon()
does not call the resize methods, it just changes the source.@oparoz @georgehrke
The text was updated successfully, but these errors were encountered: