Previews sending the mimetype icon have a wrong size

[nickvergessen]

1. Upload an empty text file
2. Open the preview:
   http://localhost/index.php/core/preview.png?file=/test.txt&x=150&y=150

Expected

The preview is 150*150 pixels

Actual

The preview is 16*16pixels

Analysis

\OC_Preview::getMimeIcon() does not call the resize methods, it just changes the source.

@oparoz @georgehrke

[georgehrke]

@oparoz IIRC You modified the mimetype-fallback to use a centered 16x16 icon, right?

The preview is 150*150 pixels

We can't scale up the svg, because that would introduce a hard-dependency on imagick. Scaling up the png is not good.

This is kind of part of the discussion, whether or not the preview api should return mimetype-icons at all (which it should not IMHO) or if it should just send some error code instead. In the case of an error code, the js should take care of using the svg mime type icon instead.

[nickvergessen]

Well the problem is, activity app already checks whether the mimetype is supported, to avoid this request.

Oh, I just discovered the isAvailable() method, so I can use that, it will take away the blurriness, but still the size is smaller.

[jancborchardt]

Do I need to fix anything here with the filetype icons? I hope not right, because previously it was generated from the SVG up to 150*150px, right?

[rullzer]

This should be fixed once #18675 is merged.
I removed the returning of the icon there since I agree with @oparoz the current behaviour is weird.

Also now that we have the mimetype js stuff there is no need for it.

[oparoz]

OK, so 3 things need to happen if we want to fix this in 8.2:

1. Re-open @rullzer's core/ajax/preview.php to controller #18675 or add an additional check to the ajax endpoint so that scripts get the proper status code
2. Fix all the core methods which query that endpoint so that they use the mimetype.js SVG fallback. (Make sure IE8 gets its nice, stretched 150x150 PNG of the 16x16 icon)
3. Remove the mimeicon fallback from preview (if the mobile team is OK with that cc @davivel)

[davivel]

For mobile apps we prefer error code. Removing MIME icon fallback is fine for us.

Thanks for the ping :)

[ghost]

it looks like we won't be fixing this until 9.0

[PVince81]

backlog for now, not critical (please tell if you think otherwise)

[ownclouders]

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.