Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view->getPath($id) returns strange path for delete files #18509

Closed
nickvergessen opened this issue Aug 24, 2015 · 9 comments · Fixed by #16479
Closed

view->getPath($id) returns strange path for delete files #18509

nickvergessen opened this issue Aug 24, 2015 · 9 comments · Fixed by #16479
Assignees
Milestone

Comments

@nickvergessen
Copy link
Contributor

If a file is deleted and moved to the trashbin, getPath($id) returns _trashbin/$path.$timestamp.
Looks like we just cut off files no ignoring whether it is files/ or not.

Is this intended? @icewind1991 @PVince81

@PVince81
Copy link
Contributor

Unlikely to be intended.

We should probably limit getPath() to return files under "files" or from ext storages.

@PVince81 PVince81 added this to the 8.2-current milestone Aug 24, 2015
@nickvergessen
Copy link
Contributor Author

Okay, maybe it's a question of setting up. When you use chroot('/user/files') the problem exists. Using chroot('/user/files/') does not have the problem. But then you need to have all paths without leading slash.

So I think it's still worth fixing

@PVince81
Copy link
Contributor

This also affects federated shares where the source was moved to trash.

@PVince81
Copy link
Contributor

The view's root is "/root/files" and it calls "getRelativePath('/root/files_trashbin/files/tetsac.d1440425391')". This sounds like the known getRelativePath issues: #16479

@PVince81
Copy link
Contributor

Mega-dirty-quickfix:

    $ownerView->chroot($ownerView->getRoot() . '/');

@PVince81
Copy link
Contributor

Also happens in setupFromToken for public shares... I guess it's time to revive #16479

@PVince81
Copy link
Contributor

In my case it looks like #16479 fixes the issue.
Can you try it too ?

@ghost
Copy link

ghost commented Sep 23, 2015

@PVince81 @nickvergessen pick up this issue again?

@nickvergessen
Copy link
Contributor Author

Well it is fixed by #16479 which is waiting for merge iirc

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants