Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview does not update after overwrite #16338

Closed
PVince81 opened this issue May 13, 2015 · 7 comments · Fixed by #16342
Closed

Preview does not update after overwrite #16338

PVince81 opened this issue May 13, 2015 · 7 comments · Fixed by #16342

Comments

@PVince81
Copy link
Contributor

Steps

  1. Upload a file "test.txt" in the web UI
  2. Wait for the preview to appear
  3. Change the file locally then upload it again, select "New files" in the overwrite dialog

Expected result

Preview is updated

Actual result

The preview blinks once as if it is being reloaded, but still shows the old contents.

Versions

ownCloud 8.1 master (4789e87)
Works properly on 8.0.3 => regression

Any idea @oparoz @georgehrke ?
A bisect could help.

@PVince81 PVince81 added this to the 8.1-current milestone May 13, 2015
@georgehrke georgehrke self-assigned this May 13, 2015
@georgehrke
Copy link
Contributor

@icewind1991 Did some file hooks change?

@PVince81
Copy link
Contributor Author

Note: the WebDAV PUT is missing some hooks calls: #16292
But this also happens with web UI upload, so not sure

@oparoz
Copy link
Contributor

oparoz commented May 13, 2015

@georgehrke - I know this happened recently, but it seems OK
https://github.com/owncloud/core/pull/16099/files

@georgehrke
Copy link
Contributor

No, it doesn't ^^
the default should be true and not false

@georgehrke
Copy link
Contributor

will send a pull request

@oparoz
Copy link
Contributor

oparoz commented May 13, 2015

Ah :)

@georgehrke
Copy link
Contributor

fix is here: #16342

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants