Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ownCloud Right Side File / Folder Details #16308

Closed
MTRichards opened this issue May 12, 2015 · 16 comments
Closed

ownCloud Right Side File / Folder Details #16308

MTRichards opened this issue May 12, 2015 · 16 comments
Labels
Milestone

Comments

@MTRichards
Copy link
Contributor

As a user, I want details about file and folder options to show on the right side of the screen when I mouse over a file or folder so that I can set comments, tags, see file details and make and remove sharing options.

Acceptance Criteria:

  • Essentially providing a construct to use the right side real estate on the files view
  • Details would include full File name, the ownCloud owner (share owner or this user if not shared with this user), create time, last modified time, type (mimetype), Size
  • Comments would be a linear oldest to newest
  • Each of the categories of additional info (details, comments, tags, sharing) would be via a twisty of some kind so that the selected feature could use more of the real estate than the rest as per the user's decision. By default, file sharing is opened, and all details of a selected file or folder are shown.

Could look something like this (help!):
untitled

@jancborchardt I know you have some thoughts here, can you help with a rough design?

@MTRichards MTRichards added this to the 8.2-next milestone May 12, 2015
@MorrisJobke
Copy link
Contributor

Redesign sharing dialog: #3224

@jancborchardt
Copy link
Member

First work-in-progress of a sidebar: #16414

@jancborchardt
Copy link
Member

Rough mockup:

(source in the design repo)

@schiessle
Copy link
Contributor

Just a idea I had while looking at the mockup: Should the sidebar also handle versions. For consistency reasons I think this could be a good idea. Opinions?

@MTRichards
Copy link
Contributor Author

yes I think it should.

@jancborchardt
Copy link
Member

@schiesbn yes it should be – ideally inside the Activity tab because version are also chronological information. As you see the top entry »Updated by you minutes ago« would create a new version. And it would be possible to restore that from there.

@schiessle
Copy link
Contributor

@jancborchardt makes sense. Although this could conflict with the current way our expire algorithm works, we don't only expire the oldest versions but also versions in between. So not all update activities will have a version attached which could be quite irritating from a user point of view.

Another thought: At some point the activity tab probably needs a way to filter for comments, changes, etc. to make it easier to get an overview and to focus on the information you are looking for.

@PVince81 PVince81 mentioned this issue Jun 25, 2015
8 tasks
@MTRichards
Copy link
Contributor Author

For files and folders that are renamed, can we add a file detail about "file or folder originally shared as" option so that people can know if things got renamed? Clearly this would also be searchable...

@schiessle
Copy link
Contributor

For files and folders that are renamed, can we add a file detail about "file or folder originally shared as" option so that people can know if things got renamed? Clearly this would also be searchable...

We could add something like this. From the technical point of view this would mean that we would need a extra column in the share table and of course quite some code to retrieve the name, display it, search it and maybe even track name changes (see below). Quite some complexity which we should only add if we see a real value in it.

One general thought to make sure that we understand the overall problem correct before we are looking for a solution: The main reason why we want to have this is that the owner can say to a group of people something like "I have shared file foo.txt with you, please have a look". But what happens if the owner renamed the file a week later from foo.txt to bar.txt? The next time he talks to someone he would probably say "I have shared file bar.txt with you, please have a look". So maybe what we really want is not the name of the file when it was shared but the current name of the original file? On the other hand you could argue that this is a privacy issue if you always expose the current filename from the owner to the recipients.

Maybe what we really want are Permalinks #11732 instead of trying to keep different filenames in sync?

@PVince81
Copy link
Contributor

Let's use this as the main ticket for the right sidebar work.

And raise separate tickets for the different sub-tasks:

@jancborchardt can you update the list of requirements (or delete them if they are obsolete) ?
Your PR mentions a few #16414 (comment) but I'm not sure whether they still match the latest discussions.

@PVince81
Copy link
Contributor

@DeepDiver1975 @blizzz FYI

@jancborchardt
Copy link
Member

@PVince81 updated the list in #16414 (comment) and linked the file actions dropdown issue: #12081

@PVince81
Copy link
Contributor

Raised #17665 for moving the share dialog.

@PVince81
Copy link
Contributor

Raised #18164 to work on the generic event/activity mechanism that should allow to mix activities, comments and versions.

@PVince81
Copy link
Contributor

The sharing dialog PR is here, for reference: #18185

@jancborchardt
Copy link
Member

Closing because this is basically done. The only parts left are tracked in their own respective issues: #16325 (tagging) and #18185 (sharing to sidebar pull request)

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants