Versions not created when updated via webdav

[rullzer]

When updating a file via webdav there is no version created. So basically if the sync client is used no version history.

Command used:

curl -X PUT --header "Content-Type:application/octet-stream" --data-binary @foo.txt http://user:pass@localhost/owncloud/remote.php/webdav/foo.txt

Of course with modifications to the data file.
The file is actually updated. But no new version is added.

I assume it is a bug. But could be that is just not yet properly implemented.

[karlitschek]

There must be something wrong

[PVince81]

This used to work => regression

[PVince81]

@rullzer have you done any bisect before ?

[PVince81]

It could be related to the "view" bypass implemented in the sabre file class which works directly on the storage. But AFAIK it should still manually trigger the hooks after putting the file, which would then trigger the versions code.

Needs further research.

[PVince81]

I'll bisect this

[PVince81]

Regression introduced by #12006 from @icewind1991 where we work directly on the storage. Maybe for some reason hooks and stuff do not get triggered properly.

I'll try and debug this.

[PVince81]

I see that hooks are triggered properly, they do reach the trashbin and sharing propagator. But somehow they don't reach the versions code, maybe the hook wasn't registered properly in this situation.

[PVince81]

@icewind1991 we seem to be missing the pre-hooks. Only post hooks are triggered. Was this on purpose or just an omission ?

We probably need to trigger the "create", "update" and "write" hooks too. Not sure when. Need to check when they were triggered in the "old" version.

[PVince81]

PR here: #16292

[nickvergessen]

PR merged