Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work directly on storage in chunk upload mode #15647

Closed
PVince81 opened this issue Apr 15, 2015 · 7 comments
Closed

Work directly on storage in chunk upload mode #15647

PVince81 opened this issue Apr 15, 2015 · 7 comments
Milestone

Comments

@PVince81
Copy link
Contributor

Follow up from: #12006

This needs to be done for the chunking mode too.

@icewind1991 as discussed here https://github.com/owncloud/core/pull/12006/files#r28233056

@DeepDiver1975 8.1 or 8.2 ?

@karlitschek
Copy link
Contributor

How Intrusive would this be?

@PVince81
Copy link
Contributor Author

As intrusive as the original fix for non-chunking mode: #12006

@PVince81
Copy link
Contributor Author

assuming that the part file assembling is the one that goes directly to the storage instead of using the view. It shouldn't be too different to the other one. It's just that the code is partly duplicated in other places.

@karlitschek karlitschek modified the milestones: 8.2-next, 8.1-current May 6, 2015
@PVince81
Copy link
Contributor Author

Looks like we might need this for the files locking to work, to avoid double locking.

@PVince81
Copy link
Contributor Author

@icewind1991 didn't you have a PR for this already ? Or maybe I mixed it up with something else.

@icewind1991
Copy link
Contributor

#17811 does chunk assembly direct on the storage

@PVince81
Copy link
Contributor Author

Right, that was the one. I was confused because it combined the lock fix as well.

Closing.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants