Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagepng() expects parameter 1 to be resource #14036

Closed
philfry opened this issue Feb 10, 2015 · 18 comments · Fixed by #14883
Closed

imagepng() expects parameter 1 to be resource #14036

philfry opened this issue Feb 10, 2015 · 18 comments · Fixed by #14883

Comments

@philfry
Copy link

philfry commented Feb 10, 2015

Hi,

pictures are showing up fine when using "files", but when trying to browse them using the gallery ("pictures") I only get the spinning circle.

The logs show:

"app":"PHP","message":"imagepng() expects parameter 1 to be resource, boolean given  at \/var\/www\/html\/owncloud\/lib\/private\/image.php#292","level":3,"time":"2015-02-10T10:22:51+00:00","method":"GET","url":"\/index.php\/apps\/gallery\/ajax\/thumbnail\/batch?token=&image=...
"app":"core","message":"OC_Image->data. Error getting image data.","level":3,"time":"2015-02-10T10:22:51+00:00","method":"GET","url":"\/index.php\/apps\/gallery\/ajax\/thumbnail\/batch?token=&image=...

Regards,

Phil

@PVince81
Copy link
Contributor

@icewind1991 @oparoz

@oparoz
Copy link
Contributor

oparoz commented Feb 10, 2015

I think it's an issue with the Image class not properly checking the response it gets from the preview provider. I encountered the problem when working on the Preview class.
@georgehrke

@ghost
Copy link

ghost commented Feb 10, 2015

Very likely a duplicate of: owncloud/gallery#158 (Issue tracker of the gallery app is probably a better place to report this. :-))

@MorrisJobke
Copy link
Contributor

Gallery issue -> something for the gallery bug tracker -> close

@oparoz
Copy link
Contributor

oparoz commented Feb 27, 2015

The error is non-blocking, but there is still a core issue.

imagepng() expects parameter 1 to be resource, boolean given

The method data() is using $this->resource, without even checking that it has one.
The default value for resource is false.

I think @georgehrke should still take a look and make that function more robust.

@MorrisJobke MorrisJobke reopened this Feb 27, 2015
@MorrisJobke MorrisJobke changed the title "gallery" remains empty in 8.0.0-19 imagepng() expects parameter 1 to be resource Feb 27, 2015
@oparoz
Copy link
Contributor

oparoz commented Feb 27, 2015

Thanks!

@itn3rd77
Copy link
Contributor

I am facing this bug since ownCloud v8.0 and it´s really really frustrating to have a broken gallery with only a spinning circle. In my humble opinion this isn't a low priority bug. We are talking about a core functionality that is completly broken for every person affected!

Any news or quick fixes to apply myself are relly appreciated.

Regards,

Ingo

@MorrisJobke
Copy link
Contributor

cc @nickvergessen because you also dig into this maybe

@oparoz
Copy link
Contributor

oparoz commented Mar 13, 2015

@itheiss - Which browser?

@georgehrke
Copy link
Contributor

I can take a look this evening, should be fairly easy to fix.

Please excuse my brevity and typos.
Sent from my mobile

On Mar 13, 2015, at 3:11 PM, Morris Jobke [email protected] wrote:

cc @nickvergessen because you also dig into this maybe


Reply to this email directly or view it on GitHub.

@itn3rd77
Copy link
Contributor

@oparoz I am using Chrome v 40.0.2214.111 m on Windows 7

@oparoz
Copy link
Contributor

oparoz commented Mar 13, 2015

@itheiss - Thanks. I just wanted to make sure you were not on Internet Explorer :)

@georgehrke
Copy link
Contributor

@itheiss can you validate that #14883 fixes the issue?

@itn3rd77
Copy link
Contributor

@georgehrke The error 'imagepng() expects parameter 1 to be resource, boolean given' is gone but the spinning circle remains. It seems to me the thumbnail generation stops at a specific image. Is the a way to enable traceing to see which images are processed? Maybe we can get a clou which image is causing the problem?

@oparoz
Copy link
Contributor

oparoz commented Mar 13, 2015

@itheiss - You're affected by owncloud/gallery#158 and owncloud/gallery#159

You'll have better luck switching to Gallery+: https://apps.owncloud.com/content/show.php/Gallery%2B?content=169116

@itn3rd77
Copy link
Contributor

@oparoz Thanks for pointing me to Gallery+. Works like a charm!

@MorrisJobke MorrisJobke added this to the 8.1-current milestone Mar 16, 2015
@MorrisJobke
Copy link
Contributor

stable8 #14917

@Trefex
Copy link

Trefex commented Mar 30, 2015

👍 affects me

@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants