Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Favorite] Files and folders explored from shared tabs in the side panel can't be favorited. #13321

Closed
SergioBertolinSG opened this issue Jan 13, 2015 · 10 comments

Comments

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Jan 13, 2015

Steps to reproduce

  1. User1 has shared files with User2.
  2. User2 enters in the Shared with you tab in the side panel.

Expected behaviour

You can make files and folders favorite from this tab.

Actual behaviour

There aren't stars to make them favorite.

Server configuration

Operating system:
Ubuntu 14.04 LTS

Web server:
Apache

Database:
MySQL

PHP version:
5.5.9

ownCloud version: (see ownCloud admin page)
{"installed":true,"maintenance":false,"version":"8.0.0.1","versionstring":"8.0 alpha 1","edition":""}

Updated from an older ownCloud or fresh install:
fresh

List of activated apps:
none

The content of config/config.php:

Insert your config.php content here
(Without the database password and passwordsalt)

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: no

Client configuration

Browser:
Chrome

cc @jancborchardt

@jancborchardt
Copy link
Member

@PVince81 is there any specific reason the stars aren’t shown on those views?

@PVince81
Copy link
Contributor

Yes, missing data. The sharing API doesn't return the favorite info.

@PVince81 PVince81 added this to the 8.1-next milestone Jan 13, 2015
@PVince81
Copy link
Contributor

Postpone to 8.1 as discussed with @DeepDiver1975

@PVince81
Copy link
Contributor

CC @schiesbn

@PVince81
Copy link
Contributor

One suggestion for the far future would be to have a WebDAV endpoint for shares and let API consumer decide whether they want the "oc:favorite" property or not, as it would affect performance to always return it.

@jancborchardt
Copy link
Member

If we use favorites in the UI, they should be in every view I would say. It’s a pretty basic feature of file management nowadays. But yeah, we do need to balance it with performance.

@PVince81
Copy link
Contributor

I agree, let's keep this ticket open to look into that.

@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1-current, 8.2-next Mar 3, 2015
@DeepDiver1975 DeepDiver1975 modified the milestones: backlog, 8.2-next Jul 3, 2015
@PVince81
Copy link
Contributor

PVince81 commented Oct 7, 2016

Best would be if we could just retrieve these shared file lists through Webdav, just like the tags search does. This way all properties that the web UI needs would always be there and displayable in any view.

@PVince81
Copy link
Contributor

Works for me in 10.0.3. As far as I remember this was added recently

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants